add upgrade free space check to document#332
Merged
vickyhella merged 1 commit intoharvester:mainfrom Jul 4, 2023
Merged
Conversation
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
w13915984028
force-pushed
the
doc4052
branch
3 times, most recently
from
a524f91 to
ad028f5
Compare
bk201
reviewed
Jun 12, 2023
Member
Author
|
I changed the please take a further look, thanks. |
LucasSaintarbor
approved these changes
Jun 19, 2023
Contributor
LucasSaintarbor
left a comment
LucasSaintarbor
left a comment
There was a problem hiding this comment.
Small nit to add the "Caution" note line 148. LGTM 👍
Signed-off-by: Jian Wang <w13915984028@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue:
harvester/harvester#4052
The upgrade will check free disk space in each node and deny if not met. User may customize the limitation.
original issue and PR:
harvester/harvester#2935
harvester/harvester#3700