Add multi CSI support summary and csi-driver-config setting#372
Add multi CSI support summary and csi-driver-config setting#372LucasSaintarbor merged 15 commits intoharvester:mainfrom
Conversation
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
futuretea
left a comment
There was a problem hiding this comment.
LGTM, thanks. Just need to squash commits
There was a problem hiding this comment.
#3666 also introduce:
- Add a new option
os.persistent_state_pathsto the Harvester OS configuration. - Add a new option
os.after_install_chroot_commandsto the Harvester OS configuration.
Both would need to add into install/harvester-configuration.md
@lanfon72 I added |
|
Thank you @LucasSaintarbor, it looks good enough for me. 😸 I think it should be fine to not update the content of For Footnotes |
|
@LucasSaintarbor Thanks! This note https://github.com/harvester/harvester/blob/master/enhancements/20230316-multi-csi-support.md?plain=1#L137 also need to be included. |
…ge with URL in Harvester config (harvester#372 (comment))
|
@futuretea Added the note you referenced for making changes persistent across an upgrade (#372 (comment)) @lanfon72 Added info and example about accessing a domain name to install package using an URL (#372 (comment)) PTAL, thanks! |
…r#372) * Adding setting definition for `csi-driver-config` * Add Multi Container Storage Interface support section to StoageClass page * Small changes * Add link to docs/advanced/settings.md#csi-driver-config * Fix link to ## `csi-driver-config` * Add `os.persistent_state_paths` and `os.after_install_chroot_commands` to Harvester configuration * Add note for os.after_install_chroot_commands (https://github.com/harvester/harvester/blob/master/enhancements/20230316-multi-csi-support.md?plain=1#L137) * Rephrase `os.after_install_chroot_commands` note * Added info and example about accessing a domain name to install package with URL in Harvester config (harvester#372 (comment)) * Rephrased note on making changes persistent across an upgrade
|
I've modified the content and pushed a few commits. There was some description of the procedure that was clumsy and which is now simplified, and some important stuff that was missing. I tried to follow the formatting changes but I'm not sure I have it right. At any rate the semantic content is complete as far as I can tell, as long as no reviewers find errors. |
References harvester/harvester#2405, harvester/harvester#3666
Documents multi CSI support on StorageClass page and explains how to edit the new
csi-driver-configsetting