Open
Conversation
Signed-off-by: clayton <hello@claytonc.dev>
Better reflects the new url sourcing capabilities. Signed-off-by: clayton <hello@claytonc.dev>
clanktron
force-pushed
the
local-config-support
branch
from
b4694a7 to
a15a98a
Compare
Vicente-Cheng
requested review from
starbops and
tserong
and removed request for
starbops and
tserong
Contributor
|
Let's clarify the user scenario first, then we can do the PR review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Currently only remote http urls are allowed to be used for sourcing a harvester config file in the installation process. Sourcing a config file from the local filesystem instead can be useful in many cases.
Solution:
By simply adding support for the
file://url prefix in thegetURL()function, one can source from the local system without any invasive changes to the codebase.Related Issue(s):
Issue harvester/harvester#9124
Testing:
A relevant unit test is bundled with this PR. Proper e2e functionality was also manually checked on multiple systems.