Conversation
The image is required for several one-shot pods. Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
There was a problem hiding this comment.
Pull request overview
Adds a missing Rancher utility image to the repository’s Rancher image allowlist so air-gapped cluster provisioning (and enabling Monitoring/CRDs) doesn’t fail due to an unavailable image.
Changes:
- Add
docker.io/rancher/kuberlr-kubectl:v6.0.0back to the Rancher image list used for image mirroring/air-gap preparation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Vicente-Cheng
left a comment
There was a problem hiding this comment.
thanks for the quick fix!
There was a problem hiding this comment.
LGTM, thanks for the fix.
BTW:
On commit 483d831, when bumping rancher-monitoring, this image was set to docker.io/rancher/kuberlr-kubectl:v6.0.0
and due to the image was shared by rancher-monitoring and rancher
it was replaced on later commit b0992d0
Not like the keeping bumping rancher, the rancher-monitoring normally keeps a version for some time.
We need to keep the docker.io/rancher/kuberlr-kubectl:v6.0.0 for rancher-monitoring on v180/master-head, and also keep another version (v7.0.1 for now) which matches embedded Rancher's (v2.14.0-alpha9) usage.
The txt based file seems not easy to comment on some images saying they are locked by some charts :)
I will try to set a used image list on rancher-monitoring addon side, and use a script to check if the expected images are on the list, to avoid such mistake.
Problem:
A new cluster can't be provisioned in an air-gapped environment because the
docker.io/rancher/kuberlr-kubectl:v6.0.0image is missing. Monitoring CRDs is a prerequisite for many charts. The monitoring addon also need this image.Solution:
Add the image back.
Related Issue(s):
Test plan:
Additional documentation or context
@w13915984028 I'd keep the v7.0.1 image because it's supposed to be used by Rancher v2.14.0-alpha9.