enhancement: drop BIOS support from harvester-installer binary#1243
Draft
tserong wants to merge 2 commits intoharvester:masterfrom
Draft
enhancement: drop BIOS support from harvester-installer binary#1243tserong wants to merge 2 commits intoharvester:masterfrom
tserong wants to merge 2 commits intoharvester:masterfrom
Conversation
We need to eventually remove support for legacy BIOS systems. Removing BIOS support from the harvester-installer binary is part of that journey. I could arguably have made the installer fail a lot earlier in the process than what I've done here, but the real goal is to leave something readable on the console that indicates what went wrong if someone attempts a PXE install on a BIOS host. It shouldn't be possible to run the installer interactively on a BIOS system anymore because the ISO doesn't support BIOS boot since v1.8.0. Oh, wait, unless maybe someone were to do my `kexec` hack to boot into the installation environment. Hrm. Might need to rework this slightly. Also we should drop the Force MBR stuff as this will now be obsolete. Related-to: harvester/harvester#9855 Signed-off-by: Tim Serong <tserong@suse.com>
Signed-off-by: Tim Serong <tserong@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
We need to eventually remove support for legacy BIOS systems. Removing BIOS support from the harvester-installer binary is part of that journey.
Solution:
Make the installer fail when run on BIOS systems. I could arguably have made the installer fail a lot earlier in the process than what I've done here, but the real goal is to leave something readable on the console that indicates what went wrong if someone attempts a PXE install on a BIOS host. It shouldn't be possible to run the installer interactively on a BIOS system anymore because the ISO doesn't support BIOS boot since v1.8.0. Oh, wait, unless maybe someone were to do my
kexechack to boot into the installation environment. Hrm. Might need to rework this slightly. Also we should drop the Force MBR stuff as this will now be obsolete.Related Issue(s):
harvester/harvester#9855
Test plan:
TBD
Additional documentation or context
Note that we only want installation to fail. The harvester-installer binary should still show the dashboard when run on existing BIOS systems that have been upgraded.
This change is going to break any CI which runs on BIOS VMs.