Draft
Conversation
- Get dependency chart versions from build.yaml because it's the single source of truth. - Get appVersions from rancher/charts. - Create a static file "scripts/rancher/deps.yaml" to store the dependency versions. Append the content to harvester-release.yaml during build time. This file should be updated when a developer bumps Rancher. The previous method is to determine the latest dependency chart versions by listing the chart directories in the image. It's unreliable because RC version is considered newer than the formal version. For example: ``` $ yq e '.entries.fleet[].version' rancher-charts.yaml | sort -V -r 109.0.0+up0.15.0-rc.6 109.0.0+up0.15.0-rc.5 109.0.0+up0.15.0-rc.3 109.0.0+up0.15.0-rc.2 109.0.0+up0.15.0-rc.1 109.0.0+up0.15.0-beta.4 109.0.0+up0.15.0 ``` Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
Add a workflow to ensure dependency versions are correct and a workflow to validate chart tarball are packaged in the Rancher image. Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The previous method is to determine the latest dependency chart versions by listing the chart directories in the image. It's unreliable because RC version is considered newer than the formal version. For example:
This causes the ISO contain the wrong chart/appVersion and upgrade script will waiting for the wrong versions.
Solution:
Append the content to harvester-release.yaml during build time.
This file should be updated when a developer bumps Rancher.
Related Issue(s):
harvester/harvester#10312
Test plan:
Run
cat scripts/rancher/deps.yamlshould get (for Rancher v2.14.0)`scripts/version-rancherto a different version.Additional documentation or context