fix(controller): decouple ippool from nad (backport #44)#46
Merged
Conversation
IPPool, VirtualMachineNetworkConfig, and NetworkAttachmentDefinition resources have tight relations. Use labels to store the referenced IPPool name in NetworkAttachmentDefinition. VirtualMachineNetworkConifg will first use its NetworkName attribute to find the target NetworkAttachmentDefinition and then figure out the where the target IPPool is. Signed-off-by: Zespre Chang <zespre.chang@suse.com> (cherry picked from commit 74e7837)
starbops
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Previously, we implicitly required the IPPool name to be the same as the related NetworkAttachmentDefinition. There should be no such restriction since we already defined the
networkNameattributes in both IPPool and VirtualMachineNetworkConfig CRDs. The controllers should leverage the attributes to build the relationship between IPPools and NetworkAttachmentDefinitions and reference the target IPPool.Solution:
IPPool, VirtualMachineNetworkConfig, and NetworkAttachmentDefinition resources have tight relations. Use labels to store the referenced IPPool name in NetworkAttachmentDefinition. VirtualMachineNetworkConifg will first use its NetworkName attribute to find the target NetworkAttachmentDefinition and determine where the target IPPool is.
Related Issue:
harvester/harvester#6240
Test plan:
This is an automatic backport of pull request fix(controller): decouple ippool from nad #44 done by Mergify.