Skip to content

TST: Fix plot composition test error messages#956

Merged
has2k1 merged 1 commit intomainfrom
plot-composition-error-message
Jul 18, 2025
Merged

TST: Fix plot composition test error messages#956
has2k1 merged 1 commit intomainfrom
plot-composition-error-message

Conversation

@has2k1
Copy link
Copy Markdown
Owner

@has2k1 has2k1 commented Jul 18, 2025

There are two issues:

  1. We had not "opted" into the custom error messaging for the tests.
  2. We have to be careful that we attach the result from compare_image to the original Compare instance (cmp._err) and not a copy of it.

closes #955

There are two issues:

1. We had not "opted" into the custom error messaging for the tests.
2. We have to be careful that we attach the result from compare_image to
the original Compare instance (cmp._err) and not a copy of it.

closes #955
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (7c5005f) to head (9444fef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #956   +/-   ##
=======================================
  Coverage   86.72%   86.72%           
=======================================
  Files         194      194           
  Lines       13321    13321           
  Branches     1639     1639           
=======================================
  Hits        11553    11553           
  Misses       1222     1222           
  Partials      546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@has2k1 has2k1 merged commit 097192d into main Jul 18, 2025
14 checks passed
@has2k1 has2k1 deleted the plot-composition-error-message branch July 21, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_plot_composition test failures when expecting a string but get an object description

1 participant