Skip to content

Refactor composition layout manager.#978

Merged
has2k1 merged 1 commit intomainfrom
refactor-composition-layout-manager
Sep 2, 2025
Merged

Refactor composition layout manager.#978
has2k1 merged 1 commit intomainfrom
refactor-composition-layout-manager

Conversation

@has2k1
Copy link
Copy Markdown
Owner

@has2k1 has2k1 commented Sep 2, 2025

Reduced the places where we do recursion.

Reduced the places where we do recursion.
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 95.52239% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.71%. Comparing base (e1e58ac) to head (84e6988).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plotnine/_mpl/layout_manager/_layout_tree.py 95.52% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
+ Coverage   86.61%   86.71%   +0.09%     
==========================================
  Files         194      194              
  Lines       13362    13109     -253     
  Branches     1646     1598      -48     
==========================================
- Hits        11574    11367     -207     
+ Misses       1239     1205      -34     
+ Partials      549      537      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@has2k1 has2k1 merged commit 84e6988 into main Sep 2, 2025
14 checks passed
@has2k1 has2k1 deleted the refactor-composition-layout-manager branch September 2, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant