new functions proposal #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposal for new functions async generatePrivateAndPublicKey() async updateTopic(topicId, memo, adminKey)
import of new functions
|
still learning |
kantorcodes
reviewed
Mar 22, 2025
src/index.ts
Outdated
| publicKey: string; | ||
| }> { | ||
| this.ensureInitialized(); | ||
| const privateKey = await PrivateKey.generateED25519Async(); |
There was a problem hiding this comment.
Nit: the spacing in this function is slightly off
kantorcodes
reviewed
Mar 22, 2025
src/index.ts
Outdated
| } | ||
|
|
||
| if (submitKey) { | ||
| transaction.setSubmitKey(PrivateKey.fromString(submitKey).publicKey); | ||
| } | ||
|
|
||
| const receipt = await this.executeTransaction(transaction); | ||
| const receipt = await this.executeTransaction(transaction, false); // Disable signing in executeTransaction |
There was a problem hiding this comment.
The signing should only be disabled if there's an admin key since it'll already have signed the transaction. Otherwise this function won't execute for all other cases
kantorcodes
reviewed
Mar 24, 2025
src/index.ts
Outdated
| const privateKey = PrivateKey.fromString(adminKey); | ||
| const signedTx = await transaction.sign(privateKey); | ||
|
|
||
| const receipt = await this.executeTransaction(signedTx); |
There was a problem hiding this comment.
Since you're already signing the transaction, the signer should be disabled in executeTransaction
kantorcodes
reviewed
Mar 24, 2025
src/index.ts
Outdated
|
|
||
| if (adminKey) { | ||
| const adminWithPrivateKey = PrivateKey.fromString(adminKey); | ||
| transaction.setAdminKey(adminWithPrivateKey.publicKey); | ||
| transaction = await transaction.sign(adminWithPrivateKey); | ||
| transaction.freezeWith(client); // Freeze after setting the admin key | ||
| transaction = await transaction.sign(adminWithPrivateKey); // Then sign |
There was a problem hiding this comment.
It looks like you're not disabling the signing in executeTransaction, so ultimately this transaction will still fail because its already frozen
update topic memo and create topic with memo works + randomly generated public+privatekey also works
with custom fee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal to implement 2 new functions + fix little bug with freeze inside createTopic() functions