Skip to content

Conversation

@MiguelLZPF
Copy link
Contributor

@MiguelLZPF MiguelLZPF commented Aug 11, 2025

Description

This pull request primarily focuses on codebase consistency, modernization, and cleanup for the linter, formatter and related configuration files. The most significant changes include updating Node.js and dependency management, standardizing code style and formatting, cleaning up test and build scripts, and improving maintainability by removing unused configuration files and dependencies.

Dependency and Environment Updates:

  • Updated Node.js version to 22.x in GitHub Actions workflows and simplified dependency installation steps for both ATS and mass-payout jobs. [1] [2]
  • Standardized the use of single quotes in configuration files like .github/dependabot.yaml, babel.config.cjs, and jest.config.cjs for consistency. [1] [2] [3]

Code Style and Formatting:

  • Added a .prettierignore file to specify files and directories to exclude from formatting, improving code formatting workflow.
  • Removed .prettierrc and .eslintrc.cjs, and dropped related ESLint and Prettier dependencies from package.json, indicating a move away from these tools in this package. [1] [2] [3]

Testing and Build Improvements:

  • Unified and cleaned up test and build scripts in package.json, including separating test and test:ci scripts and removing unnecessary script variants.
  • Improved Jest setup and polyfills for compatibility with ESM modules and consistent mocking behavior. [1] [2] [3] [4]

Code Modernization:

  • Refactored addLicence.js to use ES module syntax and improved code readability and normalization logic. [1] [2] [3] [4]
  • Standardized import statements and string usage (single quotes) throughout application files, e.g., App.tsx and CancelButton.tsx, for consistency and readability. [1] [2] [3] [4] [5]

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

  • Run linter and formatter

Node version:

  • 20
  • 22
  • 24

Test Results (if any)

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

@MiguelLZPF MiguelLZPF self-assigned this Aug 11, 2025
@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Aug 11, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@MiguelLZPF MiguelLZPF added Refactor CI | CD Changes related to CI CD, GitHub Actions, pipeline Improvement Code changes driven by non business requirements labels Aug 11, 2025
Signed-off-by: Miguel_LZPF <[email protected]>
… Mapper class for cleaner key renaming; add bridge helpers in HederaWalletConnectTransactionAdapter to handle type mismatches

Signed-off-by: Miguel_LZPF <[email protected]>
…ed variables

- Updated interfaces to use `type` instead of `interface` for better clarity and consistency.
- Removed unnecessary ESLint disable comments for unused variables and explicit `any` types across multiple files.
- Enhanced error handling by renaming caught errors to avoid shadowing.
- Simplified conditional checks and improved code readability in various classes and methods.
- Standardized the use of `object` type in place of empty interfaces for better type safety.

Signed-off-by: Miguel_LZPF <[email protected]>
…ove unused variables"

This reverts commit 4b7068e.

Signed-off-by: Miguel_LZPF <[email protected]>
…ry eslint directives

- Removed explicit 'any' type usage in various files to enhance type safety.
- Replaced empty interfaces with type aliases for better clarity.
- Updated error handling to use consistent variable naming for caught errors.
- Simplified conditional checks and improved readability in several methods.
- Cleaned up eslint disable comments to maintain code quality standards.

Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF MiguelLZPF force-pushed the refactor/linter-formater-to-root branch from 7eb3726 to 112a2c5 Compare August 12, 2025 10:21
@MiguelLZPF MiguelLZPF marked this pull request as ready for review August 12, 2025 11:02
@MiguelLZPF MiguelLZPF requested review from a team as code owners August 12, 2025 11:02
@MiguelLZPF MiguelLZPF requested a review from andrewb1269 August 12, 2025 11:02
@MiguelLZPF MiguelLZPF merged commit 0588126 into refactor/add-workspaces Aug 14, 2025
9 checks passed
@MiguelLZPF MiguelLZPF deleted the refactor/linter-formater-to-root branch August 14, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI | CD Changes related to CI CD, GitHub Actions, pipeline Improvement Code changes driven by non business requirements Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants