-
Notifications
You must be signed in to change notification settings - Fork 17
refactor: linter and formater to root #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MiguelLZPF
merged 16 commits into
refactor/add-workspaces
from
refactor/linter-formater-to-root
Aug 14, 2025
Merged
refactor: linter and formater to root #560
MiguelLZPF
merged 16 commits into
refactor/add-workspaces
from
refactor/linter-formater-to-root
Aug 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
…uality Signed-off-by: Miguel_LZPF <[email protected]>
…K packages Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
…r ESLint and Prettier Signed-off-by: Miguel_LZPF <[email protected]>
…ion notes Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
… Mapper class for cleaner key renaming; add bridge helpers in HederaWalletConnectTransactionAdapter to handle type mismatches Signed-off-by: Miguel_LZPF <[email protected]>
…ed variables - Updated interfaces to use `type` instead of `interface` for better clarity and consistency. - Removed unnecessary ESLint disable comments for unused variables and explicit `any` types across multiple files. - Enhanced error handling by renaming caught errors to avoid shadowing. - Simplified conditional checks and improved code readability in various classes and methods. - Standardized the use of `object` type in place of empty interfaces for better type safety. Signed-off-by: Miguel_LZPF <[email protected]>
…ove unused variables" This reverts commit 4b7068e. Signed-off-by: Miguel_LZPF <[email protected]>
…ry eslint directives - Removed explicit 'any' type usage in various files to enhance type safety. - Replaced empty interfaces with type aliases for better clarity. - Updated error handling to use consistent variable naming for caught errors. - Simplified conditional checks and improved readability in several methods. - Cleaned up eslint disable comments to maintain code quality standards. Signed-off-by: Miguel_LZPF <[email protected]>
7eb3726 to
112a2c5
Compare
jaime-iobermudez
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI | CD
Changes related to CI CD, GitHub Actions, pipeline
Improvement
Code changes driven by non business requirements
Refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request primarily focuses on codebase consistency, modernization, and cleanup for the linter, formatter and related configuration files. The most significant changes include updating Node.js and dependency management, standardizing code style and formatting, cleaning up test and build scripts, and improving maintainability by removing unused configuration files and dependencies.
Dependency and Environment Updates:
.github/dependabot.yaml,babel.config.cjs, andjest.config.cjsfor consistency. [1] [2] [3]Code Style and Formatting:
.prettierignorefile to specify files and directories to exclude from formatting, improving code formatting workflow..prettierrcand.eslintrc.cjs, and dropped related ESLint and Prettier dependencies frompackage.json, indicating a move away from these tools in this package. [1] [2] [3]Testing and Build Improvements:
package.json, including separatingtestandtest:ciscripts and removing unnecessary script variants.Code Modernization:
addLicence.jsto use ES module syntax and improved code readability and normalization logic. [1] [2] [3] [4]App.tsxandCancelButton.tsx, for consistency and readability. [1] [2] [3] [4] [5]Type of change
Testing
Node version:
Test Results (if any)
Checklist