Skip to content

Conversation

@MiguelLZPF
Copy link
Contributor

@MiguelLZPF MiguelLZPF commented Aug 20, 2025

Description

This pull request focuses on code style consistency and minor refactoring across configuration, Solidity contracts, and documentation. The main changes include standardizing formatting in Solidity and TypeScript files, simplifying Solidity import statements and function calls, and updating documentation to reflect centralized linting and formatting. Eliminated 70%+ redundancy across module .gitignores.

⚠️ Files to be reviewed ⚠️ :

  • Format related files (prettier)
  • Linter related files (eslint and solhint)
  • gitignore files

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

@MiguelLZPF MiguelLZPF self-assigned this Aug 20, 2025
@MiguelLZPF MiguelLZPF added Bug A error that causes the feature to behave differently than what was expected based on design docs Contracts Changes related to the “contracts” module labels Aug 20, 2025
@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Aug 20, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@MiguelLZPF MiguelLZPF marked this pull request as ready for review August 27, 2025 07:08
@MiguelLZPF MiguelLZPF requested review from a team as code owners August 27, 2025 07:08
- Update main .gitignore with comprehensive patterns for dependencies, builds, and IDE files
- Add package-specific .gitignore files for contracts, SDK, and web packages
- Remove obsolete .vscode/settings.json to avoid IDE conflicts
- Ensure consistent ignore patterns across monorepo structure

Signed-off-by: Miguel_LZPF <[email protected]>
- Add comprehensive root prettier.config.mjs with unified formatting rules
- Update README.md with improved development workflow and build instructions
- Enhance dev-monorepo-migration.md with detailed configuration inheritance patterns
- Establish foundation for package-level configuration inheritance

Signed-off-by: Miguel_LZPF <[email protected]>
- Add ESLint configuration for contracts with Hardhat and Solidity support
- Implement Prettier configuration inheriting from root config
- Update package.json with new lint/format scripts and dependencies
- Configure Slither analysis with custom settings and database
- Update Hardhat configuration for enhanced development workflow
- Enhance .solcover.js and .solhint.json for comprehensive code quality

Signed-off-by: Miguel_LZPF <[email protected]>
…mass-payout

- Add ESLint configurations for SDK, web app, and mass-payout inheriting from root
- Create Prettier configurations with package-specific overrides
- Update package.json files with unified lint/format scripts across packages
- Establish consistent configuration inheritance pattern across monorepo
- Enable package-focused development with local IDE compatibility

Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF MiguelLZPF force-pushed the fix/formatter-alignment branch from c35e8d5 to 93268a6 Compare August 29, 2025 11:25
@iobroberto iobroberto deleted the fix/formatter-alignment branch September 19, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug A error that causes the feature to behave differently than what was expected based on design docs Contracts Changes related to the “contracts” module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants