Skip to content

Conversation

@iobroberto
Copy link
Member

@iobroberto iobroberto commented Sep 23, 2025

Description

The PR splits the facets into a contract with the business logic and another exposing to the BLR the function selectors contained in the facet and the supported interfaces.

It also fixes an issue related to the publish workflow.

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • Effective Tests Added ✔️
  • No reduction of Coverage

Signed-off-by: Mario Francia <[email protected]>
@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Sep 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

MiguelLZPF
MiguelLZPF previously approved these changes Sep 23, 2025
gregscullard
gregscullard previously approved these changes Sep 23, 2025
Copy link
Contributor

@gregscullard gregscullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeffreyDallas
JeffreyDallas previously approved these changes Sep 23, 2025
@iobroberto iobroberto closed this Sep 29, 2025
@luigi-io luigi-io deleted the feat/split-and-ci branch September 30, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants