Skip to content

Feat/changesets fixes #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luigi-io merged 15 commits into from
Oct 30, 2025
Merged

Feat/changesets fixes #683

luigi-io merged 15 commits into from
Oct 30, 2025

Conversation

@luigi-io
Copy link
Contributor

@luigi-io luigi-io commented Oct 6, 2025 •
edited
Loading

Description

1.17.0

Minor Changes

  • Integrate Changesets for version management and implement enterprise-grade release workflow

    Changesets Integration

    • Add Changesets configuration with fixed versioning for ATS packages (contracts, SDK, dapp)
    • Configure develop-branch strategy as base for version management
    • Add comprehensive changeset management scripts: create, version, publish, status, snapshot
    • Implement automated semantic versioning and changelog generation
    • Add @changesets/cli dependency for modern monorepo version management

    Enterprise Release Workflow

    • Implement new ats.publish.yml workflow focused exclusively on contracts and SDK packages
    • Add manual trigger with dry-run capability for safe testing before actual releases
    • Configure parallel execution of contracts and SDK publishing jobs for improved performance
    • Support automatic triggers on version tags, release branches, and GitHub releases
    • Add changeset validation workflow to enforce one changeset per PR requirement
    • Include bypass labels for non-feature changes (no-changeset, docs-only, hotfix, chore)

    Repository Configuration

    • Update .gitignore to properly track .github/ workflows while excluding build artifacts
    • Remove deprecated all.publish.yml workflow in favor of focused ATS publishing
    • Update package.json with complete changeset workflow scripts and release commands
    • Enhance documentation with new version management workflow and enterprise practices

    Benefits

    • Modern Version Management: Semantic versioning with automated changelog generation
    • Enterprise Compliance: Manual release control with proper audit trails
    • Parallel Publishing: Improved CI/CD performance with independent job execution
    • Developer Experience: Simplified workflow with comprehensive documentation
    • Quality Assurance: Mandatory changeset validation ensures all changes are documented

    This establishes a production-ready, enterprise-grade release management system that follows modern monorepo practices while maintaining backward compatibility with existing development workflows.

Patch Changes

  • No autoexecute extract methods in sc script
  • Remove duplicate logs in sc deploy script
  • Add a 2 seconds delay between deploying smart contracts and adding configurations during sc deploy script.
  • Replace proceedRecipientIds for proceedRecipientsIds in sdk
  • Display proceed recipients' data in text format in ats web
  • Add REACT_APP_NETWORK in ats web to .env to be able to select testnet, previewnet or mainnet

Type of change

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 💥
  • Documentation update 📖
  • Refactor 🔧

Testing

All tests pass and web checked with Metamask and HWC.

Node version:

  • 20
  • 22
  • 24

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • Local Tests Pass ✅
  • No reduction of Coverage ✅

ManuIOB and others added 9 commits October 6, 2025 18:51
@ManuIOB @luigi-io
fix: [BBND-1154] display data in text format (#676)
1a95e76 
Signed-off-by: Manu Fernández <[email protected]>
@themariofrancia @luigi-io
docs: update contracts version
73ee636 
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia @luigi-io
docs: update readme
7b636c0 
Signed-off-by: Mario Francia <[email protected]>
@Axel-IoBuilders @luigi-io
Fix: no autoexecute extractMethods script (#678)
80dfcb8 
Signed-off-by: Axel-IoBuilders <[email protected]>
@MiguelLZPF @luigi-io
fix: resolve flaky timestamp comparison in holder repository test (#681)
14ca247 
Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF @themariofrancia @luigi-io
feat: changesets implementation to develop branch (#645)
1cf8c65 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
@ManuIOB @luigi-io
fix: replace proceedRecipientIds for proceedRecipientsIds (#680)
e32bb88 
Signed-off-by: Manu Fernández <[email protected]>
@luigi-io
fix: remove duplicated logs in deploy.ts
f072b77 
Signed-off-by: Luigi Navarro <[email protected]>
@luigi-io
chore: generate ATS version 1.17.0
ecbd491 
Signed-off-by: Luigi Navarro <[email protected]>
@luigi-io luigi-io requested review from a team as code owners October 6, 2025 16:57
@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Oct 6, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Licenses 0 0 0 0 0 issues
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@luigi-io luigi-io added Release Issues tied to release management functions SDK Changes related to the “sdk” module Web Changes related to the “web” module labels Oct 7, 2025
nadineloepfe
nadineloepfe reviewed Oct 9, 2025
View reviewed changes
Copy link

@nadineloepfe nadineloepfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Luis!

nadineloepfe
nadineloepfe previously approved these changes Oct 9, 2025
View reviewed changes
rbarker-dev
rbarker-dev requested changes Oct 9, 2025
View reviewed changes
@luigi-io
fix: npm publish infinite loop
05b6406 
Signed-off-by: Luigi Navarro <[email protected]>
nadineloepfe
nadineloepfe previously approved these changes Oct 15, 2025
View reviewed changes
JeffreyDallas
JeffreyDallas previously approved these changes Oct 17, 2025
View reviewed changes
rbarker-dev
rbarker-dev requested changes Oct 17, 2025
View reviewed changes
@luigi-io luigi-io dismissed stale reviews from JeffreyDallas and nadineloepfe via 052be4c October 29, 2025 09:30
rbarker-dev
rbarker-dev approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@rbarker-dev rbarker-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor nits that aren't preventing merge. Approved!

@luigi-io luigi-io merged commit d2dbcda into main Oct 30, 2025
11 checks passed
@luigi-io luigi-io deleted the feat/changesets_fixes branch October 30, 2025 14:03
themariofrancia added a commit that referenced this pull request Dec 10, 2025
@luigi-io @ManuIOB
@themariofrancia @Axel-IoBuilders @MiguelLZPF
Feat/changesets fixes (#683)
f051a7e 
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
Co-authored-by: Axel-IoBuilders <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
themariofrancia added a commit that referenced this pull request Dec 10, 2025
@luigi-io @ManuIOB
@themariofrancia @Axel-IoBuilders @MiguelLZPF
Feat/changesets fixes (#683)
373b8e6 
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
Co-authored-by: Axel-IoBuilders <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbarker-dev rbarker-dev rbarker-dev approved these changes

@nadineloepfe nadineloepfe nadineloepfe approved these changes

@JeffreyDallas JeffreyDallas JeffreyDallas left review comments

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

@sergmetelin sergmetelin Awaiting requested review from sergmetelin sergmetelin is a code owner automatically assigned from hashgraph/developer-advocates

Assignees

No one assigned

Labels

Release Issues tied to release management functions SDK Changes related to the “sdk” module Web Changes related to the “web” module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@luigi-io @hedera-eng-infrastructure @JeffreyDallas @rbarker-dev @nadineloepfe @ManuIOB @themariofrancia @Axel-IoBuilders @MiguelLZPF