Skip to content

Conversation

@MiguelLZPF
Copy link
Contributor

Description

Sync PR: Aligns CODEOWNERS-protected infrastructure files between develop and main branches to prepare for develop→main merge.

Important Context: Most changes in this PR were already approved and exist on main but have diverged from develop. This sync ensures both branches have consistent infrastructure for the upcoming full merge.

New Changes Only (not yet on main):

  • e0c152eab - fix(ci): match release tags ending with -ats in publish workflow
  • 7f3400025 - fix(ci): change npm publish access from restricted to public for scoped packages

Files Updated (9 CODEOWNERS-protected files):

  • 8 workflow files (ats.publish.yml, ats.release.yml, ats.test.yml, changeset-check.yml, mp.publish.yml, mp.release.yml, mp.test.yml, workflows/README.md)
  • 1 root .gitignore

Why This PR:

  • Part 1/2 of develop→main full sync
  • Separates infrastructure changes for faster platform-ci team review
  • Enables parallel review with codebase PR (Feat/v1 #2)

Type of change

  • Refactor 🔧
  • Documentation update 📖

Testing

Verification:

  • Workflow syntax validated (linted)
  • All commits have DCO + PGP signatures
  • CI tests will run automatically on PR creation

No code logic changes - only workflow configuration alignment.

Node version: N/A (infrastructure only)

Checklist

  • Style Guidelines followed ✅
  • Documentation Updated 📚
  • Linters - No New Warnings ⚠️
  • No reduction of Coverage

Related: This PR should merge in parallel with PR #2 (codebase sync). Both are required for complete develop→main alignment.

@MiguelLZPF MiguelLZPF requested review from a team as code owners November 25, 2025 15:28
@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Nov 25, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@MiguelLZPF MiguelLZPF marked this pull request as draft November 25, 2025 15:43
MiguelLZPF added a commit that referenced this pull request Nov 25, 2025
- Add missing import of _TIME_TRAVEL_RESOLVER_KEY to TimeTravel.sol
  Solidity file-level constants are not inherited; must be imported explicitly

- Add @nestjs/cli to mass-payout SDK devDependencies
  Required for 'nest build' command to function

These pre-existing issues were exposed when CI ran comprehensive tests on PRs #710 and #711.

Signed-off-by: Miguel_LZPF <[email protected]>
…main

Updates CODEOWNERS-protected CI/CD files from develop branch:

Workflow files (8 updated/new):
- ats.publish.yml: Added ref input, fixed release tag matching,
  improved Node version and access flags
- ats.release.yml: Added release authorization checks, enhanced
  validation and changelog generation
- ats.test.yml: Updated to Node 22.x
- changeset-check.yml: Enhanced changeset validation logic
- mp.publish.yml: Synchronized with ATS improvements
- mp.release.yml: Updated release workflow
- mp.test.yml: Node version updates
- workflows/README.md: New comprehensive CI/CD documentation

Configuration files (1 updated):
- .gitignore: Updated patterns

Part 1/2 of develop->main sync (infrastructure changes only)

Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF MiguelLZPF force-pushed the feat/infrastructure-sync-from-develop branch from 48ab0d4 to 12ff4f8 Compare November 25, 2025 16:09
MiguelLZPF added a commit that referenced this pull request Nov 25, 2025
- Add missing import of _TIME_TRAVEL_RESOLVER_KEY to TimeTravel.sol
  Solidity file-level constants are not inherited; must be imported explicitly

- Add @nestjs/cli to mass-payout SDK devDependencies
  Required for 'nest build' command to function

These pre-existing issues were exposed when CI ran comprehensive tests on PRs #710 and #711.

Signed-off-by: Miguel_LZPF <[email protected]>
@MiguelLZPF
Copy link
Contributor Author

Closing to recreate from current develop branch. PR #710 passes all tests, but recreating both PRs from the same develop snapshot ensures consistency and maintains the parallel review design. New PR will be created shortly with identical changes from up-to-date develop.

@MiguelLZPF MiguelLZPF closed this Nov 26, 2025
@MiguelLZPF MiguelLZPF deleted the feat/infrastructure-sync-from-develop branch November 26, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants