Skip to content

feat: add full redeem and enhance bond/equity features #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
themariofrancia wants to merge 64 commits into from
Closed

feat: add full redeem and enhance bond/equity features #735

themariofrancia wants to merge 64 commits into from

Conversation

@themariofrancia
Copy link
Contributor

@themariofrancia themariofrancia commented Dec 9, 2025 •
edited
Loading

Major Features:

Documentation:

  • Consolidate deployment documentation (chore: updated doc #734)
  • Remove duplicate docs from main README
  • Add deployment failure recovery guide
  • Update reference deployment status

Infrastructure:

  • Improve CI workflows for reliable releases
  • Fix changesets after v2.0.0 preparation
  • Align SDK dependencies with workspace

BREAKING CHANGE: Full redeem functionality modifies redemption flow

themariofrancia and others added 30 commits September 2, 2025 13:04
@themariofrancia
feat: split and ci
5a5e421 
Signed-off-by: Mario Francia <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@jaime-iobermudez @AlbertoMolinaIoBuilders
@MiguelLZPF @themariofrancia @iobroberto @Axel-IoBuilders
refactor: review params (#614)
6fc34e4 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Roberto Delgado <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
Co-authored-by: Roberto Delgado <[email protected]>
Co-authored-by: Axel Loupias <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@jaime-iobermudez @AlbertoMolinaIoBuilders
@MiguelLZPF @themariofrancia @iobroberto @Axel-IoBuilders
fix: align sdk error mapper with the contract one (#613)
a9b3745 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Roberto Delgado <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
Co-authored-by: Roberto Delgado <[email protected]>
Co-authored-by: Axel Loupias <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@Axel-IoBuilders
fix: remove variable reassignments (#617)
9799465 
Signed-off-by: Axel Loupias <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF @luigi-io
fix: add periods to coupons (#600)
ada9181 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@Axel-IoBuilders
feat: add createToken Trex SDK (#619)
dea25d7 
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Roberto Delgado <[email protected]>
Co-authored-by: Roberto Delgado <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@ManuIOB
feat: select all roles (#624)
3a1601f 
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@ManuIOB @AlbertoMolinaIoBuilders
@MiguelLZPF @themariofrancia @iobroberto @Axel-IoBuilders
Feat: [BBND-1078] T-Rex missing features (#628)
8f80926 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Roberto Delgado <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
Co-authored-by: Roberto Delgado <[email protected]>
Co-authored-by: Axel Loupias <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@iobroberto
refactor: move comments to interfaces (#620)
ee65327 
Signed-off-by: Roberto Delgado <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@iobroberto @MiguelLZPF @themariofrancia
feat: add task to fully set trex factory at deployment (#602)
8132e67 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Roberto Delgado <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
Co-authored-by: Mario Francia <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia @MiguelLZPF @iobroberto
refactor: group all totalbalance methods
eda80c1 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Roberto Delgado <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
Co-authored-by: Roberto Delgado <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@ManuIOB
Fix: [BBND-1085] spinner in danger zone (#639)
dee9c11 
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@iobroberto
fix: trex factory deployment task (#640)
cd6b9fa 
Signed-off-by: Roberto Delgado <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
feat: remove automatic coupon creation from bond deployment (#641)
5e04faa 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
fix: formatter and linter alignment (#650)
5df185f 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@AlbertoMolinaIoBuilders @luigi-io
Bug/bbnd 1127 coupon rate decimals (#642)
5718c03 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@Axel-IoBuilders
feat: add bond beneficiaries (#660)
1ffeb05 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
feat: latest solidity version & remove license header (#649)
73aa216 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@AlbertoMolinaIoBuilders
code refactor + erc1410 issuer facet
e2469f7 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@luigi-io
fix: in web preview mode had problems with polyfills (#670)
70f02d0 
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
refactor: rename beneficiaries proceed recipients (#669)
3551899 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia @ManuIOB
feat: mass payout (#672)
0261dc2 
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@ManuIOB
fix: [BBND-1154] display data in text format (#676)
0a4e562 
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia
chore: remove redundant .gitignore files from subprojects
0fe2e5e 
Signed-off-by: Mario Francia <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@themariofrancia
Merge remote-tracking branch 'origin/develop' into develop
76c7daa 
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia @jaime-iobermudez
@AlbertoMolinaIoBuilders @MiguelLZPF @iobroberto @Axel-IoBuilders @luigi-io @ManuIOB
Feat: mass payout (#675)
135d1af 
Signed-off-by: Mario Francia <[email protected]>
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: jaime-iobermudez <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Roberto Delgado <[email protected]>
Signed-off-by: Axel Loupias <[email protected]>
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Manu Fernández <[email protected]>
Signed-off-by: Axel-IoBuilders <[email protected]>
Co-authored-by: jaime-iobermudez <[email protected]>
Co-authored-by: Alberto Molina <[email protected]>
Co-authored-by: Miguel_LZPF <[email protected]>
Co-authored-by: Roberto Delgado <[email protected]>
Co-authored-by: Axel Loupias <[email protected]>
Co-authored-by: Axel-IoBuilders <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Co-authored-by: Manu Fernández <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia
docs: update contracts version
9e1025d 
Signed-off-by: Mario Francia <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@themariofrancia
docs: update readme
3b600ed 
Signed-off-by: Mario Francia <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@Axel-IoBuilders
Fix: no autoexecute extractMethods script (#678)
ec84e71 
Signed-off-by: Axel-IoBuilders <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
fix: resolve flaky timestamp comparison in holder repository test (#681)
b4e4267 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
MiguelLZPF and others added 12 commits November 25, 2025 15:13
@MiguelLZPF
chore: align web app SDK dependency to use workspace wildcard
012ddfd 
Changed web app's SDK dependency from 'file:' protocol to wildcard '*'
to align with workspaces-based monorepo pattern.

This makes all internal ATS dependencies consistent:
- SDK → Contracts: uses '*'
- Web → SDK: now uses '*' (was 'file:')

All package versions remain at 1.17.0.

Signed-off-by: Miguel_LZPF <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
feat: sync codebase from develop (#713)
1b07b40 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@luigi-io
Feat/add_operationData_in_ClearingOperationApproved_event (#714)
9925d30 
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@AlbertoMolinaIoBuilders
Bug/1225 missing snapshot (#716)
7c6be90 
Signed-off-by: Alberto Molina <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
feat: sync infrastructure files from develop (#712)
96b3a0b 
Signed-off-by: Miguel_LZPF <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
chore: merge main into develop
305e29c 
Brings workflow fixes from PR #712 and #713 into develop branch.
Conflicts resolved: workflow files (main's version), contract/test files (develop's version).

Signed-off-by: Miguel_LZPF <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
fix(ci): comprehensive workflow improvements for reliable releases
df876d0 
Summary of changes:

1. Fixed --ignore pattern in ats.release.yml:
   - Changed from non-existent @hashgraph/mass-payout* to correct @mass-payout/* namespace

2. Simplified publish triggers in ats.publish.yml and mp.publish.yml:
   - Changed from release.published event to push.tags for automatic publishing
   - Tag push (v*-ats or v*-mp) now directly triggers publish workflow
   - No need to manually create GitHub release first

3. Removed recursive publish scripts:
   - Removed "publish": "npm publish" from contracts and SDK package.json
   - These caused npm to recursively call itself during publish lifecycle
   - Root cause of 403 errors and double-publish attempts in CI

4. Updated workflow documentation:
   - Moved .github/workflows/README.md to .github/WORKFLOWS.md
   - Updated diagrams and instructions to reflect tag-based triggers
   - Fixed --ignore patterns in manual release documentation

Signed-off-by: Miguel_LZPF <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@luigi-io
feat: [BBND-1241] add getCouponAmountFor info in see coupon view (#723)
bf52cfe 
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@luigi-io
feat: [BBND-1238] add getDividendAmountFor info in see dividend view (#…
41f23e3 
…725)

Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@MiguelLZPF
chore: remove changesets consumed in v2.0.0 release
0629fb5 
These changesets were already applied during the v2.0.0-ats release
and should not remain in develop branch.

Signed-off-by: Miguel_LZPF <[email protected]>

Signed-off-by: Mario Francia <[email protected]>
@luigi-io
BREAKING CHANGE: Feat/BBND-1249_add_full_redeem_to_web (#733)
32cb300 
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia @luigi-io
chore: updated doc (#734)
00b3c1d 
Signed-off-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
Co-authored-by: Luigi Navarro <[email protected]>
Signed-off-by: Mario Francia <[email protected]>
@themariofrancia themariofrancia requested review from a team as code owners December 9, 2025 14:35
@hedera-eng-infrastructure
Copy link

hedera-eng-infrastructure commented Dec 9, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

gregscullard
gregscullard approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@gregscullard gregscullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregscullard gregscullard gregscullard approved these changes

@andrewb1269 andrewb1269 andrewb1269 approved these changes

@rbarker-dev rbarker-dev Awaiting requested review from rbarker-dev rbarker-dev is a code owner automatically assigned from hashgraph/platform-ci

@sergmetelin sergmetelin Awaiting requested review from sergmetelin sergmetelin is a code owner automatically assigned from hashgraph/developer-advocates

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.