chore: enhance release workflow with git identity configuration and G…#500
Open
piotrswierzy wants to merge 4 commits intomainfrom
Open
chore: enhance release workflow with git identity configuration and G…#500piotrswierzy wants to merge 4 commits intomainfrom
piotrswierzy wants to merge 4 commits intomainfrom
Conversation
…PG key import. Added steps to configure git identity for the release bot and import GPG keys for signed releases in the GitHub Actions workflow. Signed-off-by: Piotr Swierzy <piotr.swierzy@blockydevs.com>
…GPG key import process. Replaced manual git identity configuration with a dedicated action for improved clarity and maintainability. Signed-off-by: Piotr Swierzy <piotr.swierzy@blockydevs.com>
Co-authored-by: Pavel Borisov <37436896+PavelSBorisov@users.noreply.github.com> Signed-off-by: Peter Swierzy <123735851+piotrswierzy@users.noreply.github.com>
.github/workflows/release.yml
Outdated
| git_config_global: true | ||
| git_user_signingkey: true | ||
| git_commit_gpgsign: true | ||
| git_tag_gpgsign: true |
Member
There was a problem hiding this comment.
git_tag_gpgsign should be set to false, due to known issues with the semantic release tooling in use
.github/workflows/release.yml
Outdated
| fi | ||
|
|
||
| - name: Import GPG key for signed releases | ||
| if: ${{ secrets.GPG_KEY_CONTENTS != '' }} |
Member
There was a problem hiding this comment.
this check isn't functional and I don't think it's needed
…ng for tags. This change enhances the release process by streamlining the signing configuration. Signed-off-by: Piotr Swierzy <piotr.swierzy@blockydevs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance release workflow with git identity configuration and GPG key import. Added steps to configure git identity for the release bot and import GPG keys for signed releases in the GitHub Actions workflow.
Description:
Related issue(s):
Fixes #327
Notes for reviewer:
Checklist