feat: getnftinfo will return its metadata and creation time by arianejasuwienas · Pull Request #225 · hashgraph/hedera-forking

arianejasuwienas · 2025-01-30T12:57:38Z

Description:

A call to the getNonFungibleTokenInfo method on the HTS address (0x167) will now correctly populate the "metadata" and "creationTime" fields.

Related issue(s):

Fixes #198

Notes for reviewer:

Until now, these fields were mocked because they were not supported by IERC721 and required a direct implementation.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

acuarica

Looking good, thanks for sending this.

contracts/MirrorNode.sol

acuarica · 2025-02-21T18:07:45Z

contracts/HtsSystemContractJson.sol

+            string memory metadata = mirrorNode().getNftMetadata(address(this), serialId);
+            string memory createdTimestamp = mirrorNode().getNftCreatedTimestamp(address(this), serialId);


we should unify these two calls to the MN into one, maybe something like getNftMetadataAndCreatedTimestamp, and extract both fields.

contracts/HtsSystemContractJson.sol

contracts/HtsSystemContract.sol

acuarica · 2025-02-21T18:49:14Z

src/index.js

+            tokenId,
+            blockNumber,
+            nrequestedSlot,
+            atob(metadata),


Let's use Buffer.from(metadata, 'base64').toString() to be consistent with similar code below.

acuarica · 2025-02-21T18:54:51Z

src/index.js

+                `Failed to get the metadata of the NFT ${tokenId}#${serialId}`
+            );
+        const timestamp = Number(created_timestamp.split('.')[0]).toString(16).padStart(64, '0');
+        const metadataEncoded = Buffer.from(metadata).toString('hex');


did you mean

Suggested change

const metadataEncoded = Buffer.from(metadata).toString('hex');

const metadataEncoded = Buffer.from(metadata, 'base64').toString('hex');

?

No, the metadata is just a raw, encoded value - it can be any string. I'm simply calculating the bytes of the string without doing anything else to it. @acuarica

src/slotmap.js

arianejasuwienas · 2025-02-24T11:08:54Z

@acuarica Thank you for review! I've applied your suggestions (except for this one: #225 (comment), where I've left a comment).

acuarica · 2025-02-24T19:19:29Z

src/index.js

+        const metadataEncoded = Buffer.from(metadata, 'utf-8').toString('hex');
+        const metadataLength = metadata.length.toString(16).padStart(64, '0');
+        const stringTypeIndicator = '40'.padStart(64, '0');
+        const bytes = `${timestamp}${stringTypeIndicator}${metadataLength}${metadataEncoded}`;


how does this work? does this request occupy multiple slots? Do we have a unit test in ERC721.t.sol to cover this? If not, we should add one.

Below are the contents of the memory starting at this slot:

https://github.com/hashgraph/hedera-forking/pull/225/files#diff-6b0194add020b3f0fb2f67f2eac675de98278882a61d442e1c7a2b9bd97b41d4R517

It is a tuple containing an int64 followed by a string, which means it may occupy more than one slot. Note that IERC721 does not use it; instead, tokenURI is stored in a separate slot. I haven't changed that for now because it makes sense - we avoid having to decode the metadata value every time tokenURI is queried. Let me know if we want to change that.

Here is this implementation with dedicated tokenUri slot removed:

#250

One test would need to be rewritten, since we have no byte comparating function prepared yet to handle this operation; since I'm not sure if we want to go this way I've skipped this test instead of rewriting it for now.

I've merged this (#250), so all changes are already included in this PR. @acuarica

I also fixed this broken test for the tokenUri.

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

… docs (#198) Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

… optional (#198) (#250) Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

acuarica · 2025-03-07T21:34:12Z

@arianejasuwienas marked this as draft because moving forward we should also include validation tests.

arianejasuwienas added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jan 30, 2025

arianejasuwienas self-assigned this Jan 30, 2025

arianejasuwienas force-pushed the 198-nft-metada-and-creation-time branch from 7134471 to 012735b Compare January 30, 2025 12:58

arianejasuwienas changed the title ~~feat: getnftinfo will return its metadata and creation time (#164)~~ feat: getnftinfo will return its metadata and creation time (#198) Jan 30, 2025

arianejasuwienas marked this pull request as ready for review January 31, 2025 08:16

arianejasuwienas requested a review from a team as a code owner January 31, 2025 08:16

acuarica suggested changes Feb 21, 2025

View reviewed changes

arianejasuwienas force-pushed the 198-nft-metada-and-creation-time branch from 18fb2c1 to 1f1b731 Compare February 24, 2025 10:58

acuarica reviewed Feb 24, 2025

View reviewed changes

arianejasuwienas requested a review from acuarica March 5, 2025 10:20

arianejasuwienas changed the title ~~feat: getnftinfo will return its metadata and creation time (#198)~~ feat: getnftinfo will return its metadata and creation time Mar 5, 2025

arianejasuwienas force-pushed the 198-nft-metada-and-creation-time branch from 8d9e7d8 to e362dc8 Compare March 7, 2025 10:31

arianejasuwienas added 5 commits March 7, 2025 16:13

feat: getnftinfo will return its metadata and creation time (#198)

4df8047

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

feat: nft creation time and metadata support in hardhat (#198)

f9ef867

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

feat: reverting not needed change (#198)

753bf5c

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

feat: mr suggestions, combining, renaming methods, specifying type in…

7384099

… docs (#198) Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

feat: nft metada and creation time token uri moved to metadata slot -…

5d88244

… optional (#198) (#250) Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

arianejasuwienas force-pushed the 198-nft-metada-and-creation-time branch from e362dc8 to 5d88244 Compare March 7, 2025 15:13

acuarica marked this pull request as draft March 7, 2025 21:31

acuarica closed this Jun 26, 2025

		string memory metadata = mirrorNode().getNftMetadata(address(this), serialId);
		string memory createdTimestamp = mirrorNode().getNftCreatedTimestamp(address(this), serialId);

	const metadataEncoded = Buffer.from(metadata).toString('hex');
	const metadataEncoded = Buffer.from(metadata, 'base64').toString('hex');

Conversation

arianejasuwienas commented Jan 30, 2025

Uh oh!

acuarica left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

acuarica Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

acuarica Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

acuarica Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

arianejasuwienas Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arianejasuwienas commented Feb 24, 2025

Uh oh!

acuarica Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

arianejasuwienas Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

arianejasuwienas Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

arianejasuwienas Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acuarica commented Mar 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arianejasuwienas Mar 5, 2025 •

edited

Loading