Skip to content

fix: Fix storeInt64 write value alignment#289

Merged
acuarica merged 5 commits intomainfrom
288-field-tokeninfotokenexpiryautorenewperiod-is-not-properly-populated
May 6, 2025
Merged

fix: Fix storeInt64 write value alignment#289
acuarica merged 5 commits intomainfrom
288-field-tokeninfotokenexpiryautorenewperiod-is-not-properly-populated

Conversation

@acuarica
Copy link
Copy Markdown
Contributor

@acuarica acuarica commented May 6, 2025

Description:

This PR fixes the storeInt64 function to properly write the given value.

In addition, it improves NatSpec comments for newly introduced libraries.

Related issue(s):

Fixes #288.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@acuarica acuarica linked an issue May 6, 2025 that may be closed by this pull request
@acuarica acuarica self-assigned this May 6, 2025
@acuarica acuarica added the bug A error that causes the feature to behave differently than what was expected based on design docs label May 6, 2025
@swirlds-automation
Copy link
Copy Markdown

swirlds-automation commented May 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

acuarica added 2 commits May 6, 2025 16:27
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica force-pushed the 288-field-tokeninfotokenexpiryautorenewperiod-is-not-properly-populated branch from 2bc7f72 to 7a2c896 Compare May 6, 2025 14:28
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (8462a80) to head (1323667).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          23       23           
  Lines        2372     2372           
  Branches      213      213           
=======================================
  Hits         2120     2120           
  Misses        194      194           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

acuarica added 3 commits May 6, 2025 16:46
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica marked this pull request as ready for review May 6, 2025 14:59
@acuarica acuarica requested review from a team as code owners May 6, 2025 14:59
@acuarica acuarica merged commit bada845 into main May 6, 2025
24 checks passed
@acuarica acuarica deleted the 288-field-tokeninfotokenexpiryautorenewperiod-is-not-properly-populated branch May 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A error that causes the feature to behave differently than what was expected based on design docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field tokenInfo.token.expiry.autoRenewPeriod is not properly populated

4 participants