Skip to content

feat: add HTS foundry scripts#291

Merged
acuarica merged 8 commits intomainfrom
add-hts-foundry-scripts
May 20, 2025
Merged

feat: add HTS foundry scripts#291
acuarica merged 8 commits intomainfrom
add-hts-foundry-scripts

Conversation

@acuarica
Copy link
Copy Markdown
Contributor

@acuarica acuarica commented May 11, 2025

Description:

This PR fixes the association methods to not revert when the provided address does not belong to an existing Hedera account. Scripts are included so the behavior can be validated against a real network.

Important

Contracts are also added into the script folder, because haveing a src folder in the example causes the remappings in the user's project to fail.

Related issue(s):

Fixes #292.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

acuarica added 7 commits May 7, 2025 19:19
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (14478fc) to head (29c71a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          23       23           
  Lines        2372     2372           
  Branches      213      213           
=======================================
  Hits         2120     2120           
  Misses        194      194           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Luis Mastrangelo <luis@swirldslabs.com>
@acuarica acuarica self-assigned this May 11, 2025
@acuarica acuarica added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label May 20, 2025
@acuarica acuarica marked this pull request as ready for review May 20, 2025 17:50
@acuarica acuarica requested review from a team as code owners May 20, 2025 17:50
Copy link
Copy Markdown
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuarica acuarica merged commit b98c08e into main May 20, 2025
25 checks passed
@acuarica acuarica deleted the add-hts-foundry-scripts branch May 20, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Foundry] Make associate/disassociate not revert when account does not exist

3 participants