feat: remove ethereum-cryptography package#299
Merged
Conversation
Signed-off-by: nikolay <n.atanasow94@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: nikolay <n.atanasow94@gmail.com>
2 tasks
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
simzzz
approved these changes
Jan 28, 2026
jasuwienas
approved these changes
Jan 28, 2026
jasuwienas
left a comment
jasuwienas
left a comment
There was a problem hiding this comment.
It looks great!
What is bothering me are the failing jobs in gh actions. This job https://github.com/hashgraph/hedera-forking/actions/runs/21401327998/job/61711283186?pr=299 appears to keep failing due to the same error each time I run it. BUt it fails on other pull requests as well so I guess it is not related to your changes
(@natanasow but this is just my assumption, we should make sure the CI pipelines aren’t failing because of this PR before wemerge it).
konstantinabl
approved these changes
Jan 28, 2026
Member
Author
|
These CI pipelines also fail on main. The PR aims to fix security alerts across current npm packages. We can open a new task for fixing the pipelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Remove
ethereum-cryptographydue to multiple security alerts and replace it withbip32andbip39.Related issue(s):
Fixes #
Notes for reviewer:
Checklist