fix: 392: PBJ codecs to provide access to raw field bytes during parsing#396
fix: 392: PBJ codecs to provide access to raw field bytes during parsing#396artemananiev merged 2 commits intomainfrom
Conversation
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
JUnit Test Report 67 files ±0 67 suites ±0 2m 40s ⏱️ - 2m 8s Results for commit b7bb743. ± Comparison against base commit c189321. This pull request removes 8 and adds 14 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Integration Test Report 383 files ±0 383 suites ±0 13m 40s ⏱️ -49s Results for commit b7bb743. ± Comparison against base commit c189321. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
The API looks good to me. Thanks a lot @artemananiev! |
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
LGTM functionally, but I left a few comments.
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoParserTools.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoParserTools.java
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/main/java/com/hedera/pbj/runtime/ProtoParserTools.java
Show resolved
Hide resolved
pbj-core/pbj-runtime/src/test/java/com/hedera/pbj/runtime/ProtoParserToolsTest.java
Show resolved
Hide resolved
tinker-michaelj
left a comment
There was a problem hiding this comment.
LGTM, tyvm @artemananiev !
… JavaDoc Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
b7bb743
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
LGTM. Thank you!
Although, you may want to check tests in the PR checks. |
|
Fix summary:
ProtoParserTools:extractRawFieldBytes()ProtoParserTools, not in generated codec classesFixes: #392
Signed-off-by: Artem Ananev artem.ananev@swirldslabs.com