Conversation
JUnit Test Report 67 files ±0 67 suites ±0 4m 54s ⏱️ + 1m 0s Results for commit 5a5f0f7. ± Comparison against base commit c82fdbc. This pull request removes 8 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
d0b5a71 to
db7d4c8
Compare
anthony-swirldslabs
previously approved these changes
Feb 28, 2025
anthony-swirldslabs
previously approved these changes
Feb 28, 2025
Signed-off-by: Ivan Malygin <ivan@swirldslabs.com>
anthony-swirldslabs
previously approved these changes
Feb 28, 2025
...va/com/hedera/pbj/compiler/impl/generators/protobuf/CodecDefaultInstanceMethodGenerator.java
Outdated
Show resolved
Hide resolved
Integration Test Report 384 files ± 0 384 suites ±0 14m 16s ⏱️ + 1m 22s Results for commit 5a5f0f7. ± Comparison against base commit c82fdbc. This pull request removes 3 and adds 373 tests. Note that renamed tests count towards both. |
artemananiev
approved these changes
Mar 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds default method to the Codec's generated code.
Related issue(s):
Fixes #404
Notes for reviewer:
Checklist