Updating and expansion of README documentation for PBJ.#412
Merged
anthony-swirldslabs merged 13 commits intomainfrom Mar 6, 2025
Merged
Updating and expansion of README documentation for PBJ.#412anthony-swirldslabs merged 13 commits intomainfrom
anthony-swirldslabs merged 13 commits intomainfrom
Conversation
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
JUnit Test Report 67 files ±0 67 suites ±0 2m 42s ⏱️ ±0s Results for commit 23f1f21. ± Comparison against base commit e016c45. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
Contributor
anthony-swirldslabs
left a comment
anthony-swirldslabs
left a comment
There was a problem hiding this comment.
Looks good overall. I left a few comments. Also, you may want to run spotless as it complains in PR checks.
Member
jsync-swirlds
left a comment
jsync-swirlds
left a comment
There was a problem hiding this comment.
Thanks for updating these.
I noticed lots of little typos, grammar and spelling slips, and homonym swaps, and commented each with a suggestion to correct.
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
Co-authored-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com> Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
…-readme # Conflicts: # pbj-core/pbj-compiler/README.md # pbj-core/pbj-grpc-helidon/README.md
Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com>
jasperpotts
dismissed stale reviews from anthony-swirldslabs and jsync-swirlds
via
23f1f21
jsync-swirlds
approved these changes
Mar 6, 2025
anthony-swirldslabs
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup docs, update where needed and add more.