Skip to content

feat: Pipeline.closeConnection#675

Merged
anthony-swirldslabs merged 1 commit intomainfrom
657-closeConnection
Nov 12, 2025
Merged

feat: Pipeline.closeConnection#675
anthony-swirldslabs merged 1 commit intomainfrom
657-closeConnection

Conversation

@anthony-swirldslabs
Copy link
Copy Markdown
Contributor

Description:
Introducing Pipeline.closeConnection() that allows a GRPC server implementation to close a client connection. See the new integration test for usage example.

Related issue(s):

Fixes #657

Notes for reviewer:
An integration test is added to verify the behavior.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
@github-actions
Copy link
Copy Markdown

JUnit Test Report

   78 files  ±0     78 suites  ±0   4m 6s ⏱️ -41s
1 347 tests ±0  1 343 ✅ ±0   4 💤 ±0  0 ❌ ±0 
7 224 runs  ±0  7 204 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit e1de970. ± Comparison against base commit 74c799c.

This pull request removes 8 and adds 7 tests. Note that renamed tests count towards both.
, 1
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0468e48@430db481, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469058@15aaf7b1
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0475ee8@7f20dfd5, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c04760f8@15651402
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0476308@79aba813, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0476518@20a18cc9
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469268@65cc3902, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469478@c79915a
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469688@a08e41b, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469898@e08d871
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469aa8@33845e3d, [Mock for EnumWithProtoMetadata, hashCode: 464852114, Mock for EnumWithProtoMetadata, hashCode: 950896305, Mock for EnumWithProtoMetadata, hashCode: 1946122836], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469cb8@23e573e
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c04694e0@15aaf7b1, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c04696f0@1a22c1ba
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c04764a0@15651402, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c04766b0@5c194652
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c04768c0@20a18cc9, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0476ad0@61555218
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469900@c79915a, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469b10@6173863f
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469d20@e08d871, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c0469f30@4ebb7bab
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c046a140@7e615c6a, [Mock for EnumWithProtoMetadata, hashCode: 1570875775, Mock for EnumWithProtoMetadata, hashCode: 1946122836, Mock for EnumWithProtoMetadata, hashCode: 929035017], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00000007c046a350@46507dda
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
, 1

@github-actions
Copy link
Copy Markdown

Integration Test Report

    406 files  +1      406 suites  +1   19m 43s ⏱️ + 3m 9s
114 838 tests +1  114 838 ✅ +1  0 💤 ±0  0 ❌ ±0 
115 079 runs  +1  115 079 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit e1de970. ± Comparison against base commit 74c799c.

This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both.
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007f8970b962e0@fbaa78e
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007f8970b96510@1ba59a7e
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007f8970b96740@22789fdf
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [1] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007ff50fb0f3c0@cb1eb1
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [2] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007ff50fb0f5f0@3c08e713
com.hedera.pbj.integration.test.ParserNeverWrapsTest ‑ [3] com.hedera.pbj.integration.test.ParserNeverWrapsTest$$Lambda/0x00007ff50fb0f820@2a6cf703
com.hedera.pbj.integration.test.grpc.GrpcCloseClientConnectionTest ‑ testCloseClientConnection()

@anthony-swirldslabs anthony-swirldslabs merged commit 531a146 into main Nov 12, 2025
12 checks passed
@anthony-swirldslabs anthony-swirldslabs deleted the 657-closeConnection branch November 12, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server side socket closure

3 participants