fix: don't compare strings with != in JSON codec#686
Merged
anthony-swirldslabs merged 1 commit intomainfrom Nov 17, 2025
Merged
fix: don't compare strings with != in JSON codec#686anthony-swirldslabs merged 1 commit intomainfrom
anthony-swirldslabs merged 1 commit intomainfrom
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
JUnit Test Report 78 files ±0 78 suites ±0 3m 59s ⏱️ ±0s Results for commit ae81d31. ± Comparison against base commit 14bc7cd. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both. |
Integration Test Report 409 files ±0 409 suites ±0 16m 10s ⏱️ + 1m 50s Results for commit ae81d31. ± Comparison against base commit 14bc7cd. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both. |
imalygin
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implementing correct string handling in JSON codec
toJSON()method to avoid using!=for string comparison.Related issue(s):
Fixes #307
Notes for reviewer:
I manually inspected the generated JSON codecs for
MessageWithStringandEverything, and they look fine now.Checklist