Merged
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
imalygin
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introducing
int Codec.DEFAULT_MAX_DEPTH = 512and using it instead ofInteger.MAX_VALUE. Ideally we'd just remove Codec methods w/o the maxDepth argument, but it appears to be impractical because we use the convenience methods in too many places.The 512 limit is way safer than the MAX_VALUE. It may seem a bit high, but then again, it should be safe for us to be able to parse all our existing data. We could consider lowering it in the future if/when we have more data points on the maxDepth in real life.
Related issue(s):
Fixes #664
Notes for reviewer:
All tests should pass.
Checklist