Conversation
We don't lock the alloc state before adding a task event. This can result in a panic when we emit allocation metrics if it happens concurrently, because the length of the slice isn't atomically updated with the contents so we end up indexing an event that's been added before the slice is valid.
mismithhisler
approved these changes
Dec 2, 2025
tgross
added a commit
that referenced
this pull request
Dec 3, 2025
In #31 we fixed a panic when adding a task event, but the fix was incomplete and just panicked again later under heavy concurrent use. This PR fixes the follow-up panic but also fixes a data race that popped up when testing the fix with a build that used `-race`.
tgross
added a commit
that referenced
this pull request
Dec 3, 2025
In #31 we fixed a panic when adding a task event, but the fix was incomplete and just panicked again later under heavy concurrent use. This PR fixes the follow-up panic but also fixes a data race that popped up when testing the fix with a build that used `-race`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't lock the alloc state before adding a task event. This can result in a panic when we emit allocation metrics if it happens concurrently, because the length of the slice isn't atomically updated with the contents so we end up indexing an event that's been added before the slice is valid.
Example panic: