Skip to content

avoid data race when writing task states #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgross merged 1 commit into from
Dec 3, 2025
Merged

avoid data race when writing task states #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions allocrunnersim/allocrunnersim.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
cinterfaces "github.com/hashicorp/nomad/client/interfaces"
"github.com/hashicorp/nomad/client/pluginmanager/drivermanager"
cstructs "github.com/hashicorp/nomad/client/structs"
"github.com/hashicorp/nomad/helper"
"github.com/hashicorp/nomad/helper/pointer"
"github.com/hashicorp/nomad/nomad/structs"
"github.com/hashicorp/nomad/plugins/device"
Expand Down Expand Up @@ -160,7 +161,6 @@ func (ar *simulatedAllocRunner) Run() {
}
event.PopulateEventDisplayMessage()
taskStates[task.Name].Events = append(taskStates[task.Name].Events, event)

taskStates[task.Name].StartedAt = time.Now()
taskStates[task.Name].State = structs.TaskStateRunning
}
Expand Down Expand Up @@ -213,6 +213,7 @@ func (ar *simulatedAllocRunner) clientAlloc(taskStates map[string]*structs.TaskS
defer ar.allocStateLock.Unlock()

// store task states for AllocState to expose
taskStates = helper.DeepCopyMap(taskStates)
ar.allocState.TaskStates = taskStates

a := &structs.Allocation{
Expand Down Expand Up @@ -345,7 +346,7 @@ func (ar *simulatedAllocRunner) stopAll() {
// Ensure we have a current copy of the task states, so that we append and
// create a correct and full list.
ar.allocStateLock.RLock()
taskStates := ar.allocState.TaskStates
taskStates := helper.DeepCopyMap(ar.allocState.TaskStates)
ar.allocStateLock.RUnlock()

// Perform the task kill, which essentially is the shutdown notification.
Expand Down Expand Up @@ -375,11 +376,8 @@ func (ar *simulatedAllocRunner) stopAll() {
}
event.PopulateEventDisplayMessage()
taskStates[task.Name].Events = append(taskStates[task.Name].Events, event)

ar.allocStateLock.Lock()
ar.allocState.TaskStates[task.Name].FinishedAt = time.Now()
ar.allocState.TaskStates[task.Name].State = structs.TaskStateDead
ar.allocStateLock.Unlock()
taskStates[task.Name].FinishedAt = time.Now()
taskStates[task.Name].State = structs.TaskStateDead
}
ar.updateAllocAndSendUpdate(taskStates)

Expand Down