Fix issue with --- still being required at foot of slide#5
Open
zolrath wants to merge 1 commit intohashicorp-services:mainfrom
Open
Fix issue with --- still being required at foot of slide#5zolrath wants to merge 1 commit intohashicorp-services:mainfrom
zolrath wants to merge 1 commit intohashicorp-services:mainfrom
Conversation
The comment above the line implies that we shouldn't have to end the slide with ---, but as-is any slide without --- will be merged with the slide that follows it. By adding an additional --- to the file we no longer need the foot ---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Based off this comment in
index.htmleach individual slide should not need to have a leading or trailing---, but currently this does not work correctly.The
intro.mdandslide1.mdslides have a trailing---at the foot of the file which allows the files to be split into individual pages.The
slide2.mdfile lacks the trailing---and matching that style on the previous or future slides leads to files being merged into a single slide.By adding
source += "---\n---"instead, we can remove the footer---from all slides and still have them display correctly.Expectation
Please check all the relevant components;
How to
README.md.---to the footer.sourceUrlsarray inindex.html.Alternatives
If the functionality listed in the comment in
index.htmlisn't actually desired the comment can be changed.