(HOLD) Reapply ember-can upgrade
#3111
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛑 HOLD: The upgrade of to the latest version of
ember-canno longer includes theember-inflectordependency, which was implicitly depended on for production builds. This PR brings in theember-inflectordependency explicitly for boundary desktop, but the api addon also needs it. This is covered by #3094 which depends on #3088 to be merged first. This PR should be merged after #3094.Description
This pull request was originally applied in #3093 and then reverted in #3107. The reason it was reverted was because it broke the Boundary Desktop client resulting in a white screen, failing to require a module

desktop/initializers/ember-data. This module existed on load, but it also has a side-effect dependency on@ember-data/request-utils/deprecation-support, which in turn has a dependency on ember-inflector. Although it should be conditionally required:macroCondition(dependencySatisfies('ember-inflector', '*')), it isn't at runtime (either because a previous version didn't include this macro condition or because for some reason this is still being truthy some how at build time by@embroider/macros, I didn't investigate):this screenshot shows the error of not finding the
ember-inflectorand the dependency of@ember-data/request-utils/deprecation-supportonember-inflectorat the bottomThe first question is why did the previous
ember-canupgrade PR not fail builds when doingember sor running our test suite? It's becauseember-cli-miragecurrently brings inember-inflector(scroll right in code block if needed):So as long as
ember-cli-mirageis included in the build we gotember-inflector.The next question is why did this work before this PR in non-ember mirage environments. That's because
ember-canmovedember-inflectorfrom dependencies to peer dependencies as part of this PR's upgrade which makes the responsibility on the consuming app to make sure its included.This is all to say that
ember-inflectoris a dependency of boundary desktop and needs to be included.How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.