Skip to content

Conversation

@priya-patel04
Copy link
Collaborator

@priya-patel04 priya-patel04 commented Dec 15, 2025

Description

Replaces time element with Hds::Time component

🎟️ Jira ticket

Screenshots (if appropriate)

Admin:

Screenshot 2026-01-07 at 3 54 26 PM Screenshot 2026-01-07 at 3 54 45 PM Screenshot 2026-01-07 at 3 54 59 PM Screenshot 2026-01-07 at 3 54 04 PM

Desktop client:

Screenshot 2026-01-07 at 3 58 20 PM

How to Test

  1. Admin UI - Go to Session recordings, Channels by connection, Channel details and Sessions route and verify time is rendered with correct format
  2. Desktop UI - Go to Sessions route and Active sessions fly out and verify time is rendered with correct format

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
boundary-ui Ready Ready Preview, Comment Jan 27, 2026 11:37pm
boundary-ui-desktop Ready Ready Preview, Comment Jan 27, 2026 11:37pm

Request Review

@priya-patel04 priya-patel04 self-assigned this Dec 15, 2025
@priya-patel04 priya-patel04 marked this pull request as ready for review December 15, 2025 23:05
@priya-patel04 priya-patel04 requested a review from a team as a code owner December 15, 2025 23:05
DhariniJeeva
DhariniJeeva previously approved these changes Jan 2, 2026
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

ZedLi
ZedLi previously approved these changes Jan 13, 2026
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update!

ZedLi
ZedLi previously approved these changes Jan 21, 2026
hashicc
hashicc previously approved these changes Jan 23, 2026
Copy link
Collaborator

@hashicc hashicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I noticed that the scrollbar jumps when hovering over the time and the tooltip appears. It looks like it's based on this system setting in macos:

Image

But I'm not sure there's anything we can do.

@priya-patel04
Copy link
Collaborator Author

Looks good!

I noticed that the scrollbar jumps when hovering over the time and the tooltip appears. It looks like it's based on this system setting in macos:

Image But I'm [not sure there's anything we can do](https://ibm-hashicorp.slack.com/archives/C09L2MVUL5S/p1750436486497829?thread_ts=1749827953.608979&cid=C09L2MVUL5S).

Thanks for pointing this out. Read the thread you shared and yeah seems like it is out of our scope unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants