-
Notifications
You must be signed in to change notification settings - Fork 33
Replace time element with Hds::Time component #3112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DhariniJeeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
...mplates/scopes/scope/session-recordings/session-recording/channels-by-connection/channel.hbs
Show resolved
Hide resolved
…time-component-refactor
ZedLi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the update!
…time-component-refactor
…time-component-refactor
hashicc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I noticed that the scrollbar jumps when hovering over the time and the tooltip appears. It looks like it's based on this system setting in macos:
But I'm not sure there's anything we can do.
c176ef3
c176ef3 to
1228e49
Compare
9ecc8be to
1228e49
Compare
81e03e5 to
b5bf97b
Compare

Description
Replaces time element with Hds::Time component
🎟️ Jira ticket
Screenshots (if appropriate)
Admin:
Desktop client:
How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.