Onboarding consul-dataplane to VBA (version bump automation) #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahethompson
added
the
pr/no-changelog
curtbushko
previously approved these changes
Oct 12, 2023
Contributor
curtbushko
left a comment
curtbushko
left a comment
There was a problem hiding this comment.
Thanks Sarah!
It looks good. I have some questions below but I will not block you on them (especially with our time difference)
version/VERSION
Outdated
| @@ -0,0 +1 @@ | |||
| 1.1.6-dev | |||
Contributor
There was a problem hiding this comment.
nitpick: I think this should be 1.3.0-dev ?
| organization = "hashicorp" | ||
| repository = "crt-workflows-common" | ||
| workflow = "bump-version" | ||
| } |
Contributor
There was a problem hiding this comment.
question: Do we need the notification here also or does that automatically happen?
notification {
on = "fail"
}
Contributor
Author
There was a problem hiding this comment.
By default, notifications will be sent on failure without this block. If you'd like to get notifications on success also, you can add:
notification {
on = "always"
}
Contributor
Author
|
@curtbushko I've moved this out of draft. I'll let you merge it in when you're ready! |
claire-labry
approved these changes
Oct 13, 2023
dhiaayachi
approved these changes
Aug 9, 2024
dhiaayachi
left a comment
dhiaayachi
left a comment
There was a problem hiding this comment.
Thank you for adding this @sarahethompson, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per - https://hashicorp.atlassian.net/wiki/spaces/RELENG/pages/2484306717/How+To+Onboard+Version+Bump+Automation
VERSIONfile and mechanics to get and set the version at build timebump-versionevent in ci.hcl that will bump the minor version on the release branch post releasecreate-release-branch.yml) that can be manually triggered to create a new release branch from main (and bump the major version on main)