Skip to content

change: use vault ttl for all non-lease secrets #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EtienneBruines wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change: use vault ttl for all non-lease secrets #2040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dependency/vault_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,13 +138,13 @@ func leaseCheckWait(s *Secret) time.Duration {
}
}

// Handle if this is a secret with a rotation period. If this is a rotating secret,
// Handle if this is a secret with a ttl but without a lease. If this is a secret with a ttl,
// the rotating secret's TTL will be the duration to sleep before rendering the new secret.
var rotatingSecret bool
if _, ok := s.Data["rotation_period"]; ok && s.LeaseID == "" {
if s.LeaseID == "" {
if ttlInterface, ok := s.Data["ttl"]; ok {
if ttlData, err := ttlInterface.(json.Number).Int64(); err == nil {
log.Printf("[DEBUG] Found rotation_period and set lease duration to %d seconds", ttlData)
log.Printf("[DEBUG] Found ttl and set lease duration to %d seconds", ttlData)
// Add a second for cushion
base = int(ttlData) + 1
rotatingSecret = true
Expand Down