fix: timeout issues for list.peerings#2042
Merged
sreeram77 merged 1 commit intohashicorp:mainfrom May 19, 2025
Merged
Conversation
tgross
requested changes
Mar 24, 2025
sreeram77
requested changes
Apr 9, 2025
The previously used `DefaultContextTimeout` does not work well with the user-definable `WaitTime`, which can easily exceed this global timeout. By removing the use of a context deadline, we follow the pattern other dependencies (like consul_peerings) use. This made `DefaultContextTimeout` unused and it was therefore removed. Fixes hashicorp#2041
sreeram77
approved these changes
May 19, 2025
Member
sreeram77
left a comment
sreeram77
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your contribution!
Member
|
@EtienneBruines once this lands in a tagged release, we can update the dependency in Nomad as well. There's a small set of pending PRs around security dependencies as well, so I imagine that'll be sooner rather than later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previously used
DefaultContextTimeoutdoes not work well with the user-definableWaitTime, which can easily exceed this global timeout.Fixes #2041