adding custom hash for all structs of compiled discovery chain#23393
Merged
adding custom hash for all structs of compiled discovery chain#23393
Conversation
rishabh-gupta-hashicorp
pushed a commit
that referenced
this pull request
Mar 31, 2026
* adding custom hash for all structs of compiled discovery chain * adding test * Adding changelog
7 tasks
Collaborator
|
📣 Hi @panman90! a backport is missing for this PR [23393] for versions [1.18,1.21] please perform the backport manually and add the following snippet to your backport PR description: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the use of hashstructure_v2 ([github.com/mitchellh/hashstructure/v2] from compiled discovery chain hashing and replaces it with explicit custom hash implementations.
Instead of relying on generic reflective hashing, compiled discovery chain types now implement targeted appendHash logic that hashes each relevant field directly. This makes the hashing behavior more explicit, deterministic, and easier to reason about for performance-sensitive discovery-chain code.
The change includes custom hashing for [CompiledDiscoveryChain] and related nested types, with deterministic handling for:
Testing & Reproduction steps
Added/updated tests in respective test files to validate behaviour:
Performance validation
Captured pprof before vs after this change with 4000 watches on one service.
Comparison shows reduced time spent in hashing-related work on the compiled chain path, with corresponding CPU improvement in that scenario. Results are shared separately.
Links
PR Checklist
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.