Skip to content

remove @ember/render-modifiers resolution#1770

Merged
Dhaulagiri merged 1 commit intomainfrom
br-render-modifier
Nov 3, 2023
Merged

remove @ember/render-modifiers resolution#1770
Dhaulagiri merged 1 commit intomainfrom
br-render-modifier

Conversation

@Dhaulagiri
Copy link
Collaborator

@Dhaulagiri Dhaulagiri commented Nov 3, 2023

📌 Summary

removes the @ember/render-modifiers resolution we had in place to work around a bug

🛠️ Detailed description

This was added in #651 to work around a specific issue we were seeing using field-guide, but we are no longer using that tool so this resolution is not needed. As an added bonus, this also moves us to the 2.1 release of @ember/render-modifiers which includes support for Ember 5.x

📸 Screenshots

~/c/w/design-system (br-render-modifier|✔) $ yarn why @ember/render-modifiers
├─ @hashicorp/design-system-components@workspace:packages/components
│  └─ @ember/render-modifiers@npm:2.1.0 [3aeb9] (via npm:^2.0.5 [3aeb9])
│
├─ ember-basic-dropdown@npm:7.2.2
│  └─ @ember/render-modifiers@npm:2.1.0 [84211] (via npm:^2.0.5 [84211])
│
├─ ember-prism@npm:0.13.0
│  └─ @ember/render-modifiers@npm:2.1.0 [84211] (via npm:^2.0.5 [84211])
│
└─ ember-stargate@npm:0.4.3
   └─ @ember/render-modifiers@npm:2.1.0 [84211] (via npm:^2.0.5 [84211])

💬 Please consider using conventional comments when reviewing this PR.

@Dhaulagiri Dhaulagiri requested a review from a team November 3, 2023 12:16
@vercel
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Nov 3, 2023 0:24am
hds-website ✅ Ready (Inspect) Visit Preview Nov 3, 2023 0:24am

@Dhaulagiri Dhaulagiri merged commit fe25ead into main Nov 3, 2023
@Dhaulagiri Dhaulagiri deleted the br-render-modifier branch November 3, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants