Skip to content

Upgrade @embroider/addon-dev to unblock gts#3513

Merged
shleewhite merged 5 commits intomainfrom
feat/unblock-gts
Jan 28, 2026
Merged

Upgrade @embroider/addon-dev to unblock gts#3513
shleewhite merged 5 commits intomainfrom
feat/unblock-gts

Conversation

@shleewhite
Copy link
Contributor

📌 Summary

If merged, this PR would unblock the rest of the gts conversions because it upgrades @embroider/addon-dev to v8 which has a fix for the whitespace issues.

Changes include also include: pull in the new rollup config from Project Solar which fixes how the sass/css files are compiled for the dist (#3237). This is because in @embroider/addon-dev v8, it stops automatically copying over all the assets to the dist unless done explicitly and the config in Project Solar fixes this.


💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hds-showcase Ready Ready Preview Jan 28, 2026 2:13pm
hds-website Ready Ready Preview Jan 28, 2026 2:13pm

Request Review

@shleewhite shleewhite changed the title Feat/unblock gts Upgrade @embroider/addon-dev to unblock gts Jan 27, 2026
@shleewhite shleewhite requested a review from didoo January 27, 2026 21:26
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@shleewhite shleewhite merged commit 17b323a into main Jan 28, 2026
15 checks passed
@shleewhite shleewhite deleted the feat/unblock-gts branch January 28, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants