-
Notifications
You must be signed in to change notification settings - Fork 51
[Project Solar / Phase 1 / Foundations] Flight icons &Icon carbonization
#3584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zamoore
wants to merge
20
commits into
project-solar/phase-1-main-feature-branch
Choose a base branch
from
project-solar/unified-icon-work
base: project-solar/phase-1-main-feature-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
99b32f5
added changeset
zamoore 4524631
updated icon component to dynamically render async loaded SVG
zamoore cbddf66
set up the new icon build system
zamoore 0a5d1da
updated showcase examples for icons
zamoore bec5f03
building icon assets
zamoore c117e26
pulling in optimizations
zamoore 6bf6a29
removed intersection observer
zamoore 4978acf
re-added the prebuild script
zamoore 5053f49
addressing PR feedback
zamoore 28eab8f
fixing test
zamoore f30a05a
fixed a race condition
zamoore e437e8b
added a changeset for the icons package
zamoore ecc70e2
responding to PR feedback
zamoore 915bd45
fixing leaky abstraction
zamoore 8fe8ad9
porting over missing styles
zamoore f0fa419
removed unused type generation
zamoore 7204c26
refactored to use a TrackedMap
zamoore 5fa19f3
added comments to enum explaining loading states
zamoore 7ab80c5
changing the way icons are loaded in
zamoore fa2c35e
readded mistakenly removed tests
zamoore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| "@hashicorp/flight-icons": minor | ||
| "@hashicorp/design-system-components": minor | ||
| --- | ||
|
|
||
| <!-- START components/icon --> | ||
| `Icon` | ||
| - Changed the way that icons are loaded in from sprite, to dynamic importing and generation at runtime | ||
| - Added support for loading Carbon icons when the user is using a Carbon theme | ||
| <!-- END --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/flight-icons": minor | ||
| --- | ||
|
|
||
| Added additional build and sync scripts which generate loader modules and types to support the transition from Flight to Carbon icons systems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,307 @@ | ||
| { | ||
zamoore marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "accessibility": "accessibility--alt", | ||
| "activity": "activity", | ||
| "alert-circle": "warning", | ||
| "alert-circle-fill": "warning--filled", | ||
| "alert-diamond": "warning--diamond", | ||
| "alert-octagon": "warning--hex", | ||
| "alert-octagon-fill": "warning--hex--filled", | ||
| "alert-triangle": "warning--alt", | ||
| "alert-triangle-fill": "warning--alt--filled", | ||
| "align-center": "text--align--center", | ||
| "align-justify": "text--align--justify", | ||
| "align-left": "text--align--left", | ||
| "align-right": "text--align--right", | ||
| "api": "api", | ||
| "archive": "box", | ||
| "arrow-down": "arrow--down", | ||
| "arrow-down-circle": "previous--outline", | ||
| "arrow-down-left": "arrow--down-left", | ||
| "arrow-down-right": "arrow--down-right", | ||
| "arrow-left": "arrow--left", | ||
| "arrow-left-circle": "next--outline", | ||
| "arrow-right": "arrow--right", | ||
| "arrow-up": "arrow--up", | ||
| "arrow-up-left": "arrow--up-left", | ||
| "arrow-up-right": "arrow--up-right", | ||
| "at-sign": "at", | ||
| "award": "recommend", | ||
| "bar-chart": "chart--column", | ||
| "bar-chart-alt": "chart--column", | ||
| "battery": "battery--empty", | ||
| "battery-charging": "battery--charging", | ||
| "beaker": "chemistry", | ||
| "bell": "notification", | ||
| "bell-active": "notification--new", | ||
| "bell-off": "notification--off", | ||
| "bookmark": "bookmark", | ||
| "bookmark-add": "bookmark--add", | ||
| "bookmark-fill": "bookmark--filled", | ||
| "bottom": "down-to-bottom", | ||
| "box": "cube", | ||
| "briefcase": "portfolio", | ||
| "bucket": "container--image", | ||
| "bug": "debug", | ||
| "build": "tools", | ||
| "bulb": "idea", | ||
| "calendar": "calendar", | ||
| "camera": "camera", | ||
| "caret": "chevron--sort", | ||
| "cast": "media-cast", | ||
| "certificate": "policy", | ||
| "channel": "network--2", | ||
| "check": "checkmark", | ||
| "check-circle-fill": "checkmark--filled", | ||
| "check-square": "checkbox--checked", | ||
| "check-square-fill": "checkbox--checked--filled", | ||
| "chevron-down": "chevron--down", | ||
| "chevron-left": "chevron--left", | ||
| "chevron-right": "chevron--right", | ||
| "chevron-up": "chevron--up", | ||
| "circle": "circle--outline", | ||
| "circle-dot": "circle--filled", | ||
| "circle-fill": "circle--solid", | ||
| "circle-half": "contrast", | ||
| "clipboard": "report", | ||
| "clipboard-checked": "task--complete", | ||
| "clipboard-x": "task--remove", | ||
| "clock": "time", | ||
| "clock-filled": "time--filled", | ||
| "closed-caption": "closed-caption", | ||
| "cloud": "cloud", | ||
| "cloud-download": "cloud--download", | ||
| "cloud-lock": "virtual-private-cloud", | ||
| "cloud-off": "cloud--offline", | ||
| "cloud-upload": "cloud--upload", | ||
| "code": "code", | ||
| "collections": "document--multiple-02", | ||
| "command": "mac--command", | ||
| "compass": "explore", | ||
| "connection-gateway": "network--4", | ||
| "cpu": "chip", | ||
| "credit-card": "purchase", | ||
| "crop": "crop", | ||
| "crosshair": "center--circle", | ||
| "dashboard": "dashboard", | ||
| "database": "data--base", | ||
| "delete": "delete", | ||
| "diamond": "diamond--outline", | ||
| "disc": "recording", | ||
| "discussion-circle": "forum", | ||
| "discussion-square": "forum", | ||
| "docs": "document", | ||
| "docs-download": "document--download", | ||
| "dollar-sign": "currency--dollar", | ||
| "dot": "dot-mark", | ||
| "download": "download", | ||
| "droplet": "rain-drop", | ||
| "duplicate": "copy", | ||
| "edit": "edit", | ||
| "end": "page--last", | ||
| "enterprise": "enterprise", | ||
| "entry-point": "port--input", | ||
| "event": "event", | ||
| "exit-point": "port--output", | ||
| "external-link": "launch", | ||
| "eye": "view", | ||
| "eye-off": "view--off", | ||
| "file": "document--blank", | ||
| "file-check": "document--tasks", | ||
| "file-minus": "document--subtract", | ||
| "file-plus": "document--add", | ||
| "file-source": "script", | ||
| "file-text": "document", | ||
| "files": "document--multiple-02", | ||
| "filter": "filter", | ||
| "filter-circle": "filter", | ||
| "filter-fill": "filter", | ||
| "fingerprint": "fingerprint-recognition", | ||
| "flag": "flag", | ||
| "folder": "folder", | ||
| "folder-plus": "folder--add", | ||
| "folder-users": "folder--shared", | ||
| "gateway": "gateway", | ||
| "gift": "gift", | ||
| "git-branch": "branch", | ||
| "git-commit": "commit", | ||
| "git-merge": "merge", | ||
| "git-pull-request": "pull-request", | ||
| "globe": "wikis", | ||
| "government": "finance", | ||
| "grid": "grid", | ||
| "grid-alt": "thumbnail--2", | ||
| "guide": "book", | ||
| "handshake": "partnership", | ||
| "hard-drive": "vmdk-disk", | ||
| "hash": "hashtag", | ||
| "headphones": "headphones", | ||
| "heart": "favorite", | ||
| "heart-fill": "favorite--filled", | ||
| "help": "help", | ||
| "hexagon": "hexagon--outline", | ||
| "hexagon-fill": "hexagon--solid", | ||
| "history": "recently-viewed", | ||
| "home": "tools", | ||
| "hourglass": "hourglass", | ||
| "identity-service": "service-id", | ||
| "identity-user": "identification", | ||
| "image": "image", | ||
| "info": "information", | ||
| "info-fill": "information--filled", | ||
| "jump-link": "jump-link", | ||
| "key": "password", | ||
| "layers": "layers", | ||
| "layout": "template", | ||
| "learn": "education", | ||
| "line-chart": "chart--line", | ||
| "line-chart-up": "chart--line", | ||
| "link": "link", | ||
| "list": "list", | ||
| "load-balancer": "load-balancer--classic", | ||
| "lock": "locked", | ||
| "logs": "cloud--logging", | ||
| "mail": "email", | ||
| "map": "map", | ||
| "map-pin": "location", | ||
| "maximize": "maximize", | ||
| "maximize-alt": "maximize", | ||
| "meh": "face--neutral", | ||
| "menu": "menu", | ||
| "mesh": "model", | ||
| "message-circle": "chat", | ||
| "message-circle-fill": "chat", | ||
| "message-square": "chat", | ||
| "message-square-fill": "chat", | ||
| "mic": "microphone", | ||
| "mic-off": "microphone--off", | ||
| "migrate": "migrate--alt", | ||
| "minimize": "minimize", | ||
| "minimize-alt": "minimize", | ||
| "minus": "subtract", | ||
| "minus-circle": "subtract--alt", | ||
| "minus-circle-fill": "subtract--filled", | ||
| "monitor": "screen", | ||
| "moon": "moon", | ||
| "more-horizontal": "overflow-menu--horizontal", | ||
| "more-vertical": "overflow-menu--vertical", | ||
| "mouse-pointer": "cursor--1", | ||
| "move": "move", | ||
| "music": "music", | ||
| "navigation": "location--current", | ||
| "navigation-alt": "location--current", | ||
| "network": "vlan", | ||
| "network-alt": "network--3", | ||
| "newspaper": "blog", | ||
| "octagon": "stop-sign", | ||
| "org": "building", | ||
| "outline": "assignment-action--usage", | ||
| "paperclip": "attachment", | ||
| "pause": "pause", | ||
| "pen-tool": "pen--fountain", | ||
| "pencil-tool": "edit", | ||
| "phone": "phone", | ||
| "phone-call": "phone--voice", | ||
| "phone-off": "phone--off", | ||
| "pie-chart": "chart--pie", | ||
| "pin": "pin", | ||
| "pipeline": "pipelines", | ||
| "play": "play", | ||
| "play-circle": "play--outline", | ||
| "plug": "plug", | ||
| "plus": "add", | ||
| "plus-circle": "add--alt", | ||
| "plus-circle-fill": "add--filled", | ||
| "power": "power", | ||
| "printer": "printer", | ||
| "radio": "connection-signal", | ||
| "reload": "restart", | ||
| "repeat": "repeat", | ||
| "replication-direct": "replicate", | ||
| "robot": "bot", | ||
| "rocket": "rocket", | ||
| "rotate-ccw": "rotate", | ||
| "rss": "rss", | ||
| "save": "save", | ||
| "scissors": "cut", | ||
| "search": "search", | ||
| "server": "bare-metal-server", | ||
| "settings": "settings", | ||
| "share": "share", | ||
| "shield": "rule", | ||
| "shield-check": "security", | ||
| "shield-off": "rule--cancelled", | ||
| "shopping-bag": "shopping--bag", | ||
| "shopping-cart": "shopping--cart", | ||
| "shuffle": "shuffle", | ||
| "sidebar": "open-panel--left", | ||
| "sidebar-hide": "side-panel--close", | ||
| "sidebar-show": "side-panel--open", | ||
| "sign-in": "login", | ||
| "sign-out": "logout", | ||
| "skip": "error", | ||
| "skip-back": "skip--back", | ||
| "skip-forward": "skip--forward", | ||
| "slash": "marginal", | ||
| "sliders": "audio-console", | ||
| "smartphone": "mobile", | ||
| "smile": "face--satisfied", | ||
| "sort-asc": "sort--ascending", | ||
| "sort-desc": "sort--descending", | ||
| "sparkle": "ai-label", | ||
| "square": "square--outline", | ||
| "square-fill": "square--solid", | ||
| "star": "star", | ||
| "star-fill": "star--filled", | ||
| "start": "page--first", | ||
| "stop-circle": "stop--outline", | ||
| "sun": "sun", | ||
| "support": "lifesaver", | ||
| "swap-horizontal": "arrows--horizontal", | ||
| "swap-vertical": "arrows--vertical", | ||
| "switcher": "switcher", | ||
| "sync-alert": "async", | ||
| "sync-reverse": "renew", | ||
| "tablet": "tablet--landscape", | ||
| "tag": "tag", | ||
| "target": "navaid--military", | ||
| "terminal": "terminal", | ||
| "terminal-screen": "terminal", | ||
| "thumbs-down": "thumbs-down", | ||
| "thumbs-up": "thumbs-up", | ||
| "tools": "tool-box", | ||
| "top": "up-to-top", | ||
| "transform-data": "character-patterns", | ||
| "trash": "trash-can", | ||
| "trend-up": "growth", | ||
| "triangle": "triangle--outline", | ||
| "triangle-fill": "triangle--solid", | ||
| "truck": "delivery-truck", | ||
| "tv": "screen", | ||
| "type": "text--scale", | ||
| "unlock": "unlocked", | ||
| "upload": "upload", | ||
| "user": "user", | ||
| "user-check": "user--admin", | ||
| "user-circle": "user--avatar", | ||
| "user-circle-fill": "user--avatar--filled", | ||
| "user-plus": "user--follow", | ||
| "users": "user--multiple", | ||
| "video": "video", | ||
| "video-off": "video--off", | ||
| "volume-2": "volume--up", | ||
| "volume-down": "volume--down", | ||
| "volume-x": "volume--mute", | ||
| "wand": "magic-wand", | ||
| "watch": "watch", | ||
| "webhook": "webhook", | ||
| "wifi": "wifi", | ||
| "wifi-off": "wifi--off", | ||
| "wrench": "tools", | ||
| "x": "close", | ||
| "x-circle": "close--outline", | ||
| "x-circle-fill": "close--filled", | ||
| "zap": "flash", | ||
| "zap-off": "flash--off", | ||
| "zoom-in": "zoom--in", | ||
| "zoom-out": "zoom--out" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.