FilterBar: Generic filter type enhancements #3591
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dchyun
commented
Feb 11, 2026
| {{on "click" this.addExtraName}} | ||
| /> | ||
| {{/if}} | ||
| <HdsTextBody @size="100"> |
Contributor
Author
There was a problem hiding this comment.
[Note] Currently upon click of the "Add name" button the dropdown will close. This issue is being solved in #3571 on the PopoverPrimitive. Once those changes are merged this example will be updated to implement the onFocusOut argument added in that PR.
bbf8312 to
b10c5f2
Compare
4 tasks
shleewhite
previously approved these changes
Feb 16, 2026
Contributor
shleewhite
left a comment
There was a problem hiding this comment.
functionality looks great! just one nit.
showcase/app/components/page-components/filter-bar/code-fragments/with-generic-filters.gts
Outdated
Show resolved
Hide resolved
shleewhite
approved these changes
Feb 18, 2026
jorytindall
approved these changes
Feb 20, 2026
Contributor
jorytindall
left a comment
There was a problem hiding this comment.
No impact on the Figma components, nice one!
zamoore
pushed a commit
that referenced
this pull request
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would improve the flexibility of the
FilterBar'sgenericfilter type in the following waysmulti-selectfilteronClearcallback to theFilterGroupthat a consumer can use to reset their contentGeneric filter demo preview
🛠️ Detailed description
Currently in the
FilterBarcomponent, thegenericfilter type only supports a single value, and a single filter for eachFilterGroup.This PR adds support to the
genericfilter type for having an array of filters, similar to themulti-selectfilter type.If filter data such as what is listed above is provided, an applied filters tag will be added for each object inside the
data. The format of the tag text will be similar to how themulti-selectfilter data is displayed.Additionally, the data type for the generic filter data now includes an optional
dismissTagTextvalue which allows the consumer to customize how the text is displayed.An
@onClearargument has also been added to theFilterGroup. When the "Clear filter" button is clicked this callback is triggered. This allows a consumer with a generic filter group to have a way of resetting it if the filter group is cleared. For example, if their filter group has an input, they can use the@onClearcallback to reset the value of it.🔗 External links
Jira ticket: HDS-5998
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.