refactor(layout/flex): remove unnecessary div special-case branch\n\n…#3633
Draft
aklkv wants to merge 1 commit intohds-5954/flex-gtsfrom
Draft
refactor(layout/flex): remove unnecessary div special-case branch\n\n…#3633aklkv wants to merge 1 commit intohds-5954/flex-gtsfrom
aklkv wants to merge 1 commit intohds-5954/flex-gtsfrom
Conversation
…Simplify template by using `(element)` helper for all tag types\ninstead of special-casing `div`. Also remove unused `eq` import\nfrom ember-truth-helpers.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Simplify template by using
(element)helper for all tag types\ninstead of special-casingdiv. Also remove unusedeqimport\nfrom ember-truth-helpers.📌 Summary
🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.