Conversation
… `symbol-js` assets made a few tweaks related to the path of the `hds-carbon-icon-map.json` file, moving from the root of the project to the pipeline `scripts` folder
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
zamoore
previously approved these changes
Mar 17, 2026
Contributor
zamoore
left a comment
zamoore
left a comment
There was a problem hiding this comment.
LGTM aside from Alex's suggestion to bump the Carbon icon version
alex-ju
approved these changes
Mar 18, 2026
didoo
deleted the
project-solar/phase-1/HDS-6024/HDS-6144/flight-icons-symbol-js__code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is the first of two PRs that cherry pick from #3237 the changes to the Flight icons tokens pipeline (done in #3584) made to generate
symbol-jsassets and use them in the "carbonized" HDSIconcomponent (the changes to the component remain in the feature branch, for now).In this way we reduce the surface area of the feature branch, which is already quite wide (per epic https://hashicorp.atlassian.net/browse/HDS-6024).
🛠️ Detailed description
In this PR I have:
symbol-jsassetshds-carbon-icon-map.jsonfile, moving it from the root of the project to the pipelinescriptsfolder🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-6144
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.