Add "library section" to the showcase page for Icon library to improve Percy coverage#3723
Merged
Add "library section" to the showcase page for Icon library to improve Percy coverage#3723
Icon library to improve Percy coverage#3723Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alex-ju
reviewed
Mar 18, 2026
showcase/app/components/page-components/icon/sub-sections/library.gts
Outdated
Show resolved
Hide resolved
didoo
force-pushed
the
fix-svgo__showcase-cherrypick
branch
from
8f5ed8d to
654780c
Compare
KristinLBradley
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
We want to make sure #3721 is not introducing any side-effect or regression in the Flight icons assets. To do that, we want to add full coverage to the icon assets via Percy.
Note: most of the changes here have been cherry picked from #3237
🛠️ Detailed description
In this PR I have:
@hashicorp/flight-iconsas local workspace (extra, not necessary, but it doesn't hurt either)IconcomponentIconcomponentIconlibraryIconlibrary🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.