Skip to content

Don't limit search to currently selected product #2954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RubenSandwich wants to merge 2 commits into from
Closed

Don't limit search to currently selected product #2954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc8a46c
Don't limit a search to a product
RubenSandwich Jan 13, 2026
357f70f
Don't show search tags
RubenSandwich Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/command-bar/commands/search/unified-search/components/dialog-body/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@
* to show a helpful "No Results" message.
*/
const tabsData = useMemo(() => {
return gatherSearchTabsData(unifiedSearchResults, currentProductSlug)
return gatherSearchTabsData(unifiedSearchResults)
}, [unifiedSearchResults, currentProductSlug])

Check warning on line 130 in src/components/command-bar/commands/search/unified-search/components/dialog-body/index.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useMemo has an unnecessary dependency: 'currentProductSlug'. Either exclude it or remove the dependency array

return (
<>
Expand Down
4 changes: 2 additions & 2 deletions src/components/command-bar/components/dialog/header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
import { IconX24 } from '@hashicorp/flight-icons/svg-react/x-24'
import { useCurrentProduct } from 'contexts'
import { Badge } from '@hashicorp/mds-react/components'
import { useCommandBar, CommandBarTag } from 'components/command-bar'

Check warning on line 10 in src/components/command-bar/components/dialog/header.tsx

View workflow job for this annotation

GitHub Actions / Lint 

'CommandBarTag' is defined but never used
import Tag from 'components/tag'

Check warning on line 11 in src/components/command-bar/components/dialog/header.tsx

View workflow job for this annotation

GitHub Actions / Lint 

'Tag' is defined but never used
import s from './command-bar-dialog.module.css'

const CommandBarDialogHeader = () => {
Expand All @@ -17,9 +17,9 @@
const {
currentCommand,
currentInputValue,
currentTags,

Check warning on line 20 in src/components/command-bar/components/dialog/header.tsx

View workflow job for this annotation

GitHub Actions / Lint 

'currentTags' is assigned a value but never used
inputRef,
removeTag,

Check warning on line 22 in src/components/command-bar/components/dialog/header.tsx

View workflow job for this annotation

GitHub Actions / Lint 

'removeTag' is assigned a value but never used
setCurrentInputValue,
} = commandBarState

Expand All @@ -31,7 +31,7 @@
return (
<div className={s.header}>
<div className={s.icon}>{currentCommand.icon}</div>
{currentTags.length > 0 ? (
{/* {currentTags.length > 0 ? (
<div className={s.headerTags}>
{currentTags.map((tag: CommandBarTag) => (
<Tag
Expand All @@ -41,7 +41,7 @@
/>
))}
</div>
) : null}
) : null} */}
<div className={s.inputWrapper}>
<input
aria-label={inputPlaceholder}
Expand Down
Loading