Potential fix for code scanning alert no. 17: Incomplete regular expression for hostnames #2955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession for hostnames Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/hashicorp/dev-portal/security/code-scanning/17
In general, to fix this category of issue you must escape literal dots and any other regex metacharacters when you intend to match them literally in hostnames. For a domain like
learn.hashicorp.com, the safe literal regex islearn\.hashicorp\.com, so the dots do not act as wildcards.For this specific test, the best minimal change that preserves intent is to change the inline regex from
/(learn.hashicorp.com)?\/search/to/^(https?:\/\/)?(learn\.hashicorp\.com)?\/search/if you want to be precise about the host, or more conservatively and minimally to/(learn\.hashicorp\.com)?\/search/. The latter keeps the existing behavior and intent (optional hostname followed by/search) while ensuring the hostname is matched literally. No imports or additional helpers are needed; we only adjust the regex literal in the test filesrc/lib/remark-plugins/rewrite-tutorial-links/__tests__/rewrite-tutorial-links.test.tsat theexpect(String(contents)).toMatch(...)line around 240.Suggested fixes powered by Copilot Autofix. Review carefully before merging.