Skip to content

Support AWS_CA_BUNDLE for S3Getter #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support AWS_CA_BUNDLE for S3Getter #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions get_s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package getter
import (
"context"
"fmt"
"io"
"net/url"
"os"
"path/filepath"
Expand Down Expand Up @@ -328,19 +329,34 @@ func (g *S3Getter) newS3Client(
region string, url *url.URL, creds *credentials.Credentials,
) (*s3.S3, error) {
var sess *session.Session
var err error

var customCABundle io.Reader
if bundlePath := os.Getenv("AWS_CA_BUNDLE"); bundlePath != "" {
customCABundle, err = os.Open(bundlePath)
if err != nil {
return nil, err
}
}

if profile := url.Query().Get("aws_profile"); profile != "" {
var err error
sess, err = session.NewSessionWithOptions(session.Options{
Profile: profile,
SharedConfigState: session.SharedConfigEnable,
CustomCABundle: customCABundle,
})
if err != nil {
return nil, err
}
} else {
config := g.getAWSConfig(region, url, creds)
sess = session.New(config)
sess, err = session.NewSessionWithOptions(session.Options{
Config: *config,
CustomCABundle: customCABundle,
})
if err != nil {
return nil, err
}
}

return s3.New(sess), nil
Expand Down