Skip to content

Conversation

shanye997
Copy link

This PR is related to hashicorp/go-getter#36151.

Should I provider an Alibaba Cloud account to run the unit tests? Could I add the account information to file .github/workflows/go-getter.yml directly?

Thanks!

@shanye997 shanye997 requested a review from a team as a code owner August 6, 2025 02:22
Copy link

hashicorp-cla-app bot commented Aug 6, 2025

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Contributor

crw commented Aug 26, 2025

Hi @shanye997, many projects at HashiCorp use go-getter to solve very specific use cases within their products. Can you say more about what the Terraform use case you want to support? Even if this change is merged, additional work will be needed in Terraform, so understanding the goal of this change will help us understand what work needs to be done. Thanks very much!

@shanye997
Copy link
Author

shanye997 commented Aug 27, 2025

Hi @shanye997, many projects at HashiCorp use go-getter to solve very specific use cases within their products. Can you say more about what the Terraform use case you want to support? Even if this change is merged, additional work will be needed in Terraform, so understanding the goal of this change will help us understand what work needs to be done. Thanks very much!

Hi @crw, This Pull Request is aimed at supporting the download of modules from an Alibaba Cloud OSS bucket. The specific usage is as follows:

module "example1" {
    source = "oss::https://bucket.oss-ap-southeast-1.aliyuncs.com/foo/bar.baz"
}

module "example2" {
    source = "oss::https://bucket.oss-ap-southeast-1.aliyuncs.com/foo/bar.baz?version=1234"
}

Do I need to provide an Alibaba Cloud account for testing, and add it directly to the .github/workflows/go-getter.yml file? Are there any additional steps required besides this?

Thank you!

@crw
Copy link
Contributor

crw commented Aug 27, 2025

Thanks for that, I've passed your comment over to the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants