fix: #538 http file download skipped if headResp.ContentLength is 0 #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvdp
force-pushed
the
fix--download-file-when-resp-header-content-size-is-0
branch
from
adff051 to
ade8cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an issue with terraform not downloading our private modules from gitlab when we do it from a location that uses the azure entra application proxy in between.
After investigation it seems that the response.contentlength is 0 in the header and the download gets skipped
it presumes the file already exists and continues to try to extract the empty archive
go-getter/get_http.go
Line 446 in e702211
changing the condition from
headResp.ContentLength >= 0toheadResp.ContentLength > 0resolves the issue for usseems that azure proxy doesnt set the content length correctly
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.