Close conn on WriteResponse errors and add Nomad to CODEOWNERS #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanmanikanta2299
approved these changes
Feb 20, 2025
tgross
added a commit
to hashicorp/net-rpc-msgpackrpc
that referenced
this pull request
Feb 24, 2025
Update go-msgpack to pick up the bug fix described in hashicorp/go-msgpack#26, which mirrors the work done here in #15
tgross
added a commit
to hashicorp/net-rpc-msgpackrpc
that referenced
this pull request
Feb 24, 2025
Update go-msgpack to pick up the bug fix described in hashicorp/go-msgpack#26, which mirrors the work done here in #15 Also bump go version for CI to a supported version.
tgross
added a commit
to hashicorp/net-rpc-msgpackrpc
that referenced
this pull request
Feb 24, 2025
Update go-msgpack to pick up the bug fix described in hashicorp/go-msgpack#26, which mirrors the work done here in #15 Also bump go version for CI to a supported version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the fix from hashicorp/net-rpc-msgpackrpc#15
For consistency only. To the best of my knowledge no HashiCorp tools use this code. They only use the serialization code from this package and all use hashicorp/net-rpc-msgpackrpc for RPC.
Also add @hashicorp/nomad-eng to CODEOWNERS as in hashicorp/go-sockaddr#75
Team will also need repo write access.