-
Notifications
You must be signed in to change notification settings - Fork 104
Hold Your Own Key Support #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
helenjw
wants to merge
7
commits into
main
Choose a base branch
from
feature/hyok
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b60638c
to
c006283
Compare
2 tasks
c006283
to
eaf7215
Compare
2 tasks
2 tasks
Co-authored-by: Helen Jiang <[email protected]>
Co-authored-by: Jarrett Spiker <[email protected]>
* initial attribute changes, wip * Add support for HYOK Configurations and OIDC Configurations (#1162) Co-authored-by: Helen Jiang <[email protected]> * Update workspace.go Co-authored-by: Jarrett Spiker <[email protected]> * Add support for HYOK Configurations and OIDC Configurations (#1162) Co-authored-by: Helen Jiang <[email protected]> * Add support for Customer Key Version and Encrypted Data Keys (#1203) Co-authored-by: Jarrett Spiker <[email protected]> * Updating attributes. * Add support for HYOK Configurations and OIDC Configurations (#1162) Co-authored-by: Helen Jiang <[email protected]> * Add support for Customer Key Version and Encrypted Data Keys (#1203) Co-authored-by: Jarrett Spiker <[email protected]> * Updating agent_pool. Added test case. * Updated agent pool integration test file. * Revert commented section. * Updating organization. WIP organization_integration_test. * Updated organization integration test. * Updating attributes. Updating test cases. * Added workspace integration test cases * Updated test cases. * Updated state_version. Updated Read test cases. * Updated hyok tests. Added environment variables. * Updated errors.go * WIP StateVersion * Updated skipHYOKIntegrationTests if-statement. * Added hyok-testing.sh to scripts folder. Finished state_version testing and new functions. * Updated uploading test. * Added comments to UploadSanitizedState. * Updated hyok test cases. * Updating state_version_mocks.go. --------- Co-authored-by: Helen Jiang <[email protected]> Co-authored-by: Jarrett Spiker <[email protected]> Co-authored-by: Helen Jiang <[email protected]>
4acf548
to
23f134f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HYOKCustomerKeyVersions
resources:List
Read
Revoke
Delete
HYOKEncryptedDataKey
resources:Read
agent_pool
related attributes:HYOKConfigurations
: read only.organization
related attributes:EnforceHYOK
: create, read, update.PrimaryHYOKConfiguration
: read only.CanUpdateHYOKConfiguration
added in OrganizationPermissions.CanViewHYOKFeatureInfo
added in OrganizationPermissions.plan
related attributes:HYOKEncryptedDataKey
: read only.SanitizedPlan
: read only.state_version
related attributes:EncryptedStateDownloadURL
: read only.SanitizedStateDownloadURL
: read only.SanitizedStateUploadURL
: read only.UploadSanitizedState()
: function to upload sanitized state.HYOKEncryptedDataKey
: read only.workspace
related attributes:HYOKEnabled
: create, read, update.HYOKEncryptedDataKey
: read only.Testing plan
All the testing cases have been documented in the other related PRs.
hyok-testing.sh
should have all the implemented test cases for this entire pull request.External links
Output from tests
If the attribute ENABLE_HYOK_INTEGRATION_TESTS is available and set to 1:

HYOK attributes:
OIDC configurations:

HYOK configurations:

If the attribute ENABLE_HYOK_INTEGRATION_TESTS is not available or not set to 1:


Rollback Plan
Changes to Security Controls
Related PRs